Improve contrast between failed and incomplete color #5121
Conversation
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
|
The progress bar now looks like this: In the dark mode the colors are exactly the same so I'm saving me the screenshot here. (It is actually not that ideal that the colors are the same but that's a different topic.) |
Commit c3af6a3 increased the contrast of progress bar segments showing the number of failures by making the color we generally use for failures darker. However, that decreased the difference between the color of failures and incompletes which makes them harder to distinguish. So this commit reverts this original change. To still have a good contrast in the progress bar segment the text color within the progress bar is set to black. This looks good in bright and dark mode (the mode actually makes no difference for the progress bars). Related ticket: https://progress.opensuse.org/issues/128783
|
I guess wider design concerns are no longer relevant as the project's been rejected... |
Codecov Report
@@ Coverage Diff @@
## master #5121 +/- ##
==========================================
- Coverage 98.25% 98.24% -0.01%
==========================================
Files 383 383
Lines 36348 36348
==========================================
- Hits 35713 35711 -2
- Misses 635 637 +2 |
|
I retriggered the OBS checks, they looked like they failed because of some OBS internal problem (e.g. readonly file system) |
|
Actually that didn't help: |
|
Oh, there's a different error actually: |
|
#5121 (comment) looks like the contrast on red is a bit too good now. Do we use some kind of gray text in the other areas? |
|
yes this one looks good |
|
The other progress bar segments are likely the normal link color. I don't think it would look good on the red background, though. We already use black for skipped progress bar segments so I thought consistency with that would be nice. Of course we could also use the normal text color in all progress bar segments that so far use black and maybe even in all progress bar segments for the best consistency. |
Yes, I also feel the same thing, just change the red to normal red, everything else is fine. |
|
At least for me, the black text on the dark red "failed jobs" bar is really hard to read. |
|
I find it easier to read than the white text¹ although both is actually pretty well readable so I have no strong opinion on that. I also don't find the red very "dark". I suppose colors are a complicated matter :-) ¹ Which failed some contrast test (see #5080). |
Yep! I've got red-green color impairment, so that could be a reason why red appears to be much darker to me. |
|
maybe we can now try to make the red a bit lighter? |
|
We can make it a little bit lighter - but not too light. It still needs good contrast with the usually white background. |
Yes, if we do more light, then the contrast will not match on the light theme mode. |
Commit c3af6a3 increased the contrast of progress bar segments showing the number of failures by making the color we generally use for failures darker. However, that decreased the difference between the color of failures and incompletes which makes them harder to distinguish. So this commit reverts this original change. To still have a good contrast in the progress bar segment the text color within the progress bar is set to black. This looks good in bright and dark mode (the mode actually makes no difference for the progress bars).