git subrepo pull (merge) external/os-autoinst-common

[perlpunk]

subrepo:
  subdir:   "external/os-autoinst-common"
  merged:   "7445334ff"
upstream:
  origin:   "git@github.com:os-autoinst/os-autoinst-common.git"
  branch:   "master"
  commit:   "6e38846c4"
git-subrepo:
  version:  "0.4.6"
  origin:   "git@github.com:ingydotnet/git-subrepo"
  commit:   "110b9eb"

[github-actions]

Great PR! Please pay attention to the following items before merging:

Files matching external/**:

• Consider doing this change in the upstream repository directly, see external/os-autoinst-common/README.md

This is an automatically generated QA checklist based on modified files.

[baierjan]

Suggested change

	perl-critic-checks:
	jobs:
	perl-critic-checks:

[perlpunk]

This PR is just a subrepo update.
Any changes in external should bereviewed and fixed over there.

[baierjan]

I know, the problem was introduced in os-autoinst/os-autoinst-common#32

[perlpunk]

checkstyle is failing:
https://app.circleci.com/pipelines/github/os-autoinst/openQA/12796/workflows/cde22364-281d-4619-9966-03d9fd6e2a01/jobs/119275

yamllint --strict $((git ls-files "*.yml" "*.yaml" 2>/dev/null || find -name '*.y*ml') | grep -v ^dbicdh)
external/os-autoinst-common/.github/workflows/base-commit-message-checker.yml
  4:1       warning  truthy value should be one of [false, true]  (truthy)

external/os-autoinst-common/.github/workflows/commit-message-checker.yml
  4:1       warning  truthy value should be one of [false, true]  (truthy)

external/os-autoinst-common/.github/workflows/perl-critic.yml
  4:1       warning  truthy value should be one of [false, true]  (truthy)
  10:2      error    syntax error: expected <block end>, but found '<block mapping start>' (syntax)
  11:5      error    wrong indentation: expected 3 but found 4  (indentation)

external/os-autoinst-common/.github/workflows/perl-lint-checks.yml
  4:1       warning  truthy value should be one of [false, true]  (truthy)

external/os-autoinst-common/dependencies.yaml
  32:24     error    no new line character at the end of file  (new-line-at-end-of-file)

make: *** [Makefile:318: test-yaml] Error 1

In the os-autoinst-common PR I did suggest to test a subrepo update before merging.
We should really enforce this for the still pending PR.

[perlpunk]

@josegomezr we are getting checkstyle failures

[baierjan]

@josegomezr we are getting checkstyle failures

That's because of #5430 (comment)

[perlpunk]

Also https://app.circleci.com/pipelines/github/os-autoinst/openQA/12796/workflows/cde22364-281d-4619-9966-03d9fd6e2a01/jobs/119279

[15:26:34] t/01-style.t .............................................. 1/? 
#   Failed test 'Consistent space before function signatures (this is not ensured by perltidy)'
#   at t/01-style.t line 20.
#          got: 'external/os-autoinst-common/tools/tidyall
# '
#     expected: ''
# Looks like you failed 1 test of 8.
[15:26:34] t/01-style.t ..............................................
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/8 subtests 

[perlpunk]

new pr: #5431