Unify Perl Critic #32
Conversation
lib/OpenQA/Test/PatchDeparse.pm
Outdated
| # This is not our code, and formatting should stay the same for | ||
| # better comparison with new versions of B::Deparse | ||
| # <---- PATCH | ||
| package B::Deparse; | ||
| no warnings 'redefine'; | ||
| no strict 'refs'; | ||
|
|
||
| *{"B::Deparse::walk_lineseq"} = sub { | ||
| *{'B::Deparse::walk_lineseq'} = sub { |
There was a problem hiding this comment.
The comment above says "This is not our code, and formatting should stay the same for better comparison with new versions of B::Deparse" so changing the formatting here seems wrong.
There was a problem hiding this comment.
The quote type changes are irrelevant to the inner workings of the code. It'll perform exactly the same task regardless of the quote.
Why keeping it out-of-style?
There was a problem hiding this comment.
"for better comparison with new versions of B::Deparse" - although I'm just quoting the comment here. I guess I personally don't care much about it.
There was a problem hiding this comment.
It says so in the comment: for better comparison with new versions of B::Deparse.
I can take a new version and do a diff to this snippet to see if anything has changed.
I just checked again, nothing has changed.
I wonder how much work it would be to create a reproducer for a bugreport. It's annoying to keep this patch around.
If it's easier, just exclude this file completely from linting instead of excluding certain lines.
There was a problem hiding this comment.
for context: https://progress.opensuse.org/issues/40895
There was a problem hiding this comment.
@josegomezr Be sure to resolve comments, or otherwise respond if you consider the matter addressed. Otherwise it looks like there's an open question here.
There was a problem hiding this comment.
Just unified tabs to spaces, does that also constitute a unacceptable change as per:
"This is not our code, and formatting should stay the same for better comparison with new versions of B::Deparse"
?
There was a problem hiding this comment.
Yes, tabs to spaces is a change.
There was a problem hiding this comment.
just to confirm: tabs to spaces is not acceptable for this file in particular?
There was a problem hiding this comment.
That part of the code should stay exactly the same. Only in this file, for the reason stated in the comment.
|
This pull request is now in conflicts. Could you fix it? 🙏 |
There was a problem hiding this comment.
Because of the discussion around B::Deparse: https://github.com/os-autoinst/os-autoinst-common/pull/32/files#r1427773102
josegomezr
force-pushed
the
add_perl_critic
branch
2 times, most recently
from
d91c023
to
8b7d4d4
Compare
|
Ping (?) |
|
Ping x2 (?) |
josegomezr
force-pushed
the
add_perl_critic
branch
from
8b7d4d4
to
14c704b
Compare
- Introducing `tools/perlcritic` an improved wrapper over perl's `perlcritic`. It automatically appends this project's policies that are defined under the `openqa` theme. - Adds a complementary GitHub Action to run `tools/perlcritic` automatically on Pull Requests & Master. - Fixed `perlcritics` complaints. Branched off os-autoinst#30. Co-authored-by: Oliver Kurz <okurz@suse.de> Co-authored-by: Martchus <martchus@gmx.net>
josegomezr
force-pushed
the
add_perl_critic
branch
from
14c704b
to
c045e31
Compare
|
os-autoinst/os-autoinst#2443 edit: all good now, we fixed a couple of things. |
Introducing
tools/perlcritican improved wrapper over perl'sperlcritic.It automatically appends this project's policies that are defined under the
openqatheme.Adds a complementary GitHub Action to run
tools/perlcriticautomatically on Pull Requests & Master.Fixed
perlcriticscomplaints.Branched off #30.