Fix build requirements in spec file when tests disabled after fc99325b #5597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The make target now needs to load `Setup.pm` so its dependencies need to be present at build time.
baierjan
approved these changes
Apr 29, 2024
okurz
requested changes
Apr 29, 2024
Comment on lines
+128
to
+129
| %else | ||
| BuildRequires: %{common_requires} %{main_requires} |
There was a problem hiding this comment.
should be handled in dependencies.yaml as part of "build_requires"
EDIT: As discussed better move OpenQA::Setup::list_assets to OpenQA::Assets::list (and setup_asset_pack) and create a separate specific list of dependencies, e.g. only Mojolicious, Mojo::File, assetpack. Consider renaming "assetpack" in dependencies.yaml to "install" so that we have "install_requires"
|
Probably a better alternative: #5598 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The make target now needs to load
Setup.pmso its dependencies need to be present at build time.