Move asset-related setup into its own file to avoid extra build requires #5598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okurz
approved these changes
Apr 29, 2024
baierjan
approved these changes
Apr 29, 2024
okurz
reviewed
Apr 29, 2024
Martchus
force-pushed
the
separate-assets-module
branch
from
6823fb7
to
4420563
Compare
okurz
approved these changes
Apr 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5598 +/- ##
=======================================
Coverage 98.40% 98.40%
=======================================
Files 392 393 +1
Lines 38287 38292 +5
=======================================
+ Hits 37677 37682 +5
Misses 610 610 ☔ View full report in Codecov by Sentry. |
|
[ 20s] + perl -I/usr/share/openqa/lib -mMojolicious -mMojo::Home -mOpenQA::Setup -e 'OpenQA::Assets::setup(Mojolicious->new(home => Mojo::Home->new("/usr/share/openqa")))' |
Otherwise we need many additional dependencies at build time. This is notable when those dependencies are not already pulled-in anyways for running tests and thus will fix builds on architectures where we have tests disabled.
Martchus
force-pushed
the
separate-assets-module
branch
from
4420563
to
6dedda7
Compare
|
Builds for all archs look good again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we need many additional dependencies at build time. This is notable when those dependencies are not already pulled-in anyways for running tests and thus will fix builds on architectures where we have tests disabled.