Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make pylint happy #5

Merged
merged 3 commits into from
Jun 9, 2021
Merged

Make pylint happy #5

merged 3 commits into from
Jun 9, 2021

Conversation

mimi1vx
Copy link
Member

@mimi1vx mimi1vx commented Jun 8, 2021

Disable some warnings

sort imports and deduplicate some code

@mimi1vx mimi1vx requested a review from asdil12 June 9, 2021 07:37
@kalikiana
Copy link
Member

I don't see pylint checks here 🤔
image

asdil12
asdil12 reviewed Jun 9, 2021
View reviewed changes
Copy link
Member

@asdil12 asdil12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe limit them on the master branch and PRs to that branch:
#6

@mimi1vx
Copy link
Member Author

mimi1vx commented Jun 9, 2021

maybe limit them on the master branch and PRs to that branch:
#6

ok, change in action removed, to use @asdil12 #6

@asdil12
Copy link
Member

asdil12 commented Jun 9, 2021

ok, change in action removed, to use @asdil12 #6

I merged #6 so that you can rebase and run the tests in this PR.

@mimi1vx mimi1vx requested a review from asdil12 June 9, 2021 08:04
@asdil12 asdil12 merged commit 766053d into os-autoinst:master Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asdil12 asdil12 asdil12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mimi1vx @kalikiana @asdil12