Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the post_fail_hook ip command to fail #165

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

perlpunk
Copy link
Contributor

@perlpunk perlpunk commented Feb 19, 2024

It may fail in case this IP is not actually set on the bridge.
Also the ctrl-c needs to happen before, because if the

grep ... tail -f -n0 nohup.out

fails, it's not killed. Since ctrl-c shouldn't do any harm, I guess we can
do it regardless of which test we are running.

This ensures that the post_fail_hook can be completed.

Also this fixes sporadic failures in openqa_from_git: https://openqa.opensuse.org/tests/3946911#step/openqa_webui/36

It may fail in case this IP is not actually set on the bridge.
Also the ctrl-c needs to happen before, because if the

    grep ... tail -f -n0 nohup.out

fails, it's not killed. Since ctrl-c shouldn't do any harm, I guess we can
do it regardless of which test we are running.

This ensures that the post_fail_hook can be completed.
@perlpunk
Copy link
Contributor Author

perlpunk commented Feb 19, 2024

Ok, now the post_fail_hook suceeds.
https://openqa.opensuse.org/tests/3947127#step/openqa_webui/49
Of course that still doesn't solve the problem, so it needs to be merged manually.
However, since I added changes (moved the ctrl-c), I will wait a bit.

tail -F will wait for the ile to appear.

It seems that the sleep 1 after the file appears is too slow and
the first line

    [info] Listening at "http://127.0.0.1:9526"

has already gone away when the grep starts.
@perlpunk
Copy link
Contributor Author

perlpunk commented Feb 19, 2024

Added another commit that improves the grepping of nohup.out, this fixes these sporadic failures:
https://openqa.opensuse.org/tests/3946911#step/openqa_webui/36

The content of the nohup.out is:

[info] Listening at "http://127.0.0.1:9526"
Web application available at http://127.0.0.1:9526
[info] Listening at "http://[::1]:9526"

So everything worked, but it still ran into the timeout, that's why I realized that the while / grep logic is broken.

@okurz
Copy link
Member

okurz commented Feb 19, 2024

this fails with the error that is fixed in #166 and #166 fails with the error that is fixed here :D Let's merge both and see how the current state in master will look like after merge.

@okurz okurz merged commit 64b2277 into os-autoinst:master Feb 19, 2024
4 of 5 checks passed
@perlpunk perlpunk deleted the ignore-command-result branch February 19, 2024 16:14
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants