Include ProhibitDeepNests perlcritic policy

os-autoinst · Nov 28, 2018 · 657b53a · 657b53a
1 parent 6b5d997
commit 657b53a
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 7 deletions.
diff --git a/.perlcriticrc b/.perlcriticrc
@@ -0,0 +1,8 @@
+[-Perl::Critic::Policy::BuiltinFunctions::ProhibitStringyEval]
+
+[Perl::Critic::Policy::HashKeyQuotes]
+
+[Perl::Critic::Policy::ConsistentQuoteLikeWords]
+
+[Perl::Critic::Policy::ControlStructures::ProhibitDeepNests]
+max_nests = 8
diff --git a/.travis.yml b/.travis.yml
@@ -21,4 +21,3 @@ install:
   - make prepare
 script:
   - make test
-  - make perlcritic
diff --git a/Makefile b/Makefile
@@ -83,13 +83,10 @@ test-static: tidy test-merge test-dry test-no-wait_idle test-unused-modules test
 ifeq ($(TESTS),compile)
 test: test-compile
 else
-test: unit-test test-static test-compile
+test: unit-test test-static test-compile perlcritic
 endif
 
-PERLCRITIC=PERL5LIB=tools/lib/perlcritic:$$PERL5LIB perlcritic --quiet \
-	--exclude Perl::Critic::Policy::BuiltinFunctions::ProhibitStringyEval \
-	--include Perl::Critic::Policy::HashKeyQuote \
-	--include Perl::Critic::Policy::ConsistentQuoteLikeWords
+PERLCRITIC=PERL5LIB=tools/lib/perlcritic:$$PERL5LIB perlcritic --quiet --gentle
 
 .PHONY: perlcritic
 perlcritic: tools/lib/

diff --git a/lib/migration.pm b/lib/migration.pm
@@ -24,7 +24,7 @@ use testapi;
 use utils;
 use registration;
 use qam 'remove_test_repositories';
-use version_utils qw(sle_version_at_least is_sle is_sles4sap);
+use version_utils qw(is_sle is_sles4sap);
 
 our @EXPORT = qw(
   setup_sle