Skip to content

Commit

Permalink
Improve handling bsc#1008493 in yast2_tftp module
Browse files Browse the repository at this point in the history
Once in a while we may match log needle, if error is not shown
immediately. So, move soft-failure further, so we actually try to close
dialog, and if it didn't work, we check if error is shown.

Be aware that this issue doesn't appear often, and wait_still_screen
would also do the trick, but we don't to wait for no reason.

See [poo#34072](https://progress.opensuse.org/issues/34072).
  • Loading branch information
Rodion Iafarov committed Apr 11, 2018
1 parent ae07371 commit 77d5cd0
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions tests/console/yast2_tftp.pm
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,17 @@ sub run {

# view log
send_key 'alt-v'; # open log window
assert_screen([qw(yast2_tftp_view_log_error yast2_tftp_view_log_show)]);
assert_screen('yast2_tftp_view_log_show');
send_key 'alt-c'; # close the window
assert_screen([qw(yast2_tftp_view_log_error yast2_tftp_closed_port)]);
if (match_has_tag('yast2_tftp_view_log_error')) {
# softfail for opensuse when error for view log throws out
record_soft_failure "bsc#1008493";
send_key 'alt-o'; # confirm the error message
wait_screen_change { send_key 'alt-o' }; # confirm the error message
assert_screen('yast2_tftp_view_log_show');
send_key 'alt-c'; # close the window
assert_screen 'yast2_tftp_closed_port';
}
send_key 'alt-c'; # close the window
assert_screen 'yast2_tftp_closed_port';
# now finish tftp server configuration
send_key 'alt-o'; # confirm changes

Expand All @@ -83,4 +86,3 @@ sub run {
}

1;

0 comments on commit 77d5cd0

Please sign in to comment.