perlcritic: Don't use while with implicit assignment to status

os-autoinst · May 3, 2019 · 7d527de · 7d527de
1 parent ee94a6c
commit 7d527de
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/mm_network.pm b/lib/mm_network.pm
@@ -27,12 +27,12 @@ sub configure_hostname {
 sub get_host_resolv_conf {
     my %conf;
     open(my $fh, '<', "/etc/resolv.conf");
-    while (<$fh>) {
-        if (/^nameserver\s+([0-9.]+)\s*$/) {
+    while (my $line = <$fh>) {
+        if ($line =~ /^nameserver\s+([0-9.]+)\s*$/) {
             $conf{nameserver} //= [];
             push @{$conf{nameserver}}, $1;
         }
-        if (/search\s+(.+)\s*$/) {
+        if ($line =~ /search\s+(.+)\s*$/) {
             $conf{search} = $1;
         }
     }