Skip to content

Commit

Permalink
Fix refreshment issue for iscsi_client
Browse files Browse the repository at this point in the history
  • Loading branch information
hjluo committed Dec 26, 2023
1 parent b1712f3 commit 9daa84b
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 31 deletions.
30 changes: 0 additions & 30 deletions lib/YaST/workarounds.pm
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ use Config::Tiny;
our @EXPORT = qw(
apply_workaround_poo124652
apply_workaround_bsc1206132
workaround_poo124652_for_send_key_until
);

=head1 Workarounds for known issues
Expand Down Expand Up @@ -78,33 +77,4 @@ sub apply_workaround_bsc1206132 {
systemctl('daemon-reload');
}

=head2 workaround_poo124652_for_send_key_until ():
Workaround screen refresh issue for the send_key_until_needle_match
Records a soft failure with a reference to bsc#1206132
This is the wrapper for send_key_until_needle_match for applying
apply_workaround_bsc1206132.
=cut

sub workaround_poo124652_for_send_key_until {
my ($tag, $key, $counter, $timeout) = @_;

$counter //= 20;
$timeout //= 1;

my $real_timeout = 0;
while (!check_screen($tag, $real_timeout)) {
wait_screen_change {
send_key $key;
};
if (--$counter <= 0) {
apply_workaround_bsc1206132 $tag;
}
$real_timeout = $timeout;
}
}

1;
2 changes: 1 addition & 1 deletion lib/yast2_widget_utils.pm
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ sub change_service_configuration_step {

send_key $shortcut;
send_key 'end';
workaround_poo124652_for_send_key_until $needle_selection, 'up', 6, 1;
send_key_until_needlematch $needle_selection, 'up', 6, 5;
if (check_var_array('EXTRATEST', 'y2uitest_ncurses')) {
send_key 'ret';
apply_workaround_poo124652($needle_check) if (is_sle('>=15-SP4'));
Expand Down

0 comments on commit 9daa84b

Please sign in to comment.