Skip to content

Commit

Permalink
Skip 2nd&3rd runs when selecting all atterns in sle15
Browse files Browse the repository at this point in the history
  • Loading branch information
jknphy committed Mar 19, 2018
1 parent f6f1609 commit b28caa5
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 9 deletions.
1 change: 1 addition & 0 deletions lib/y2logsstep.pm
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ sub workaround_dependency_issues {
sleep 2;
}
}
return 1;
}

# to break dependency issues
Expand Down
24 changes: 15 additions & 9 deletions tests/installation/select_patterns_and_packages.pm
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
use base "y2logsstep";
use strict;
use testapi;
use version_utils 'is_sle';

my $secondrun = 0; # bsc#1029660

Expand Down Expand Up @@ -154,7 +155,7 @@ sub package_action {

sub run {
my ($self) = @_;

my $dep_issue;
$self->gotopatterns;
if (get_var('PATTERNS')) {
my %wanted_patterns;
Expand Down Expand Up @@ -190,8 +191,8 @@ sub run {
};
assert_screen 'current-pattern-selected', 5;
}
$self->workaround_dependency_issues;
# stick to the default patterns
$dep_issue = $self->workaround_dependency_issues || $dep_issue; # check if at least 1 dep. issue was displayed
# stick to the default patterns
if (get_var('PATTERNS', '') =~ /default/) {
$needs_to_be_selected = $selected;
}
Expand All @@ -204,12 +205,17 @@ sub run {
}
}
$self->package_action;
$secondrun++;
$self->gotopatterns;
$self->package_action;
$secondrun--;
$self->gotopatterns;
$self->package_action('unblock');
if (is_sle('15+') and check_var('PATTERNS', 'all') and $dep_issue) {
record_soft_failure "bsc#1084064 - Cloud patterns conflicts"; # skip second & third runs
}
else {
$secondrun++;
$self->gotopatterns;
$self->package_action;
$secondrun--;
$self->gotopatterns;
$self->package_action('unblock');
}
}

1;
Expand Down

0 comments on commit b28caa5

Please sign in to comment.