Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Online tests to use Full medium as mirror #10058

Merged

Conversation

jknphy
Copy link
Contributor

@jknphy jknphy commented Apr 17, 2020

Enable certain Online scenarios to use Full medium as mirror.

Moving the scenario to Full Medium and just updating the ISO does not requires code changes. On the other hand keeping the scenarios in Online and updating the mirrors cannot be done without adding other condition here so I chose better first option for this case.

@jknphy jknphy force-pushed the scenarios_mirror_using_full_medium branch from 6f000ff to 69ee127 Compare April 17, 2020 13:50
@jknphy jknphy changed the title [WIP] Enable certain Online scenarios to use Full medium as mirror [WIP] Enable Online tests to use Full medium as mirror Apr 17, 2020
@jknphy jknphy force-pushed the scenarios_mirror_using_full_medium branch 4 times, most recently from 6943b32 to 18260fa Compare April 20, 2020 09:28
@jknphy jknphy changed the title [WIP] Enable Online tests to use Full medium as mirror Enable Online tests to use Full medium as mirror Apr 20, 2020
@jknphy jknphy requested a review from rwx788 April 20, 2020 13:56
@jknphy jknphy force-pushed the scenarios_mirror_using_full_medium branch 2 times, most recently from ad63db3 to 8ca2c7e Compare April 21, 2020 06:22
@jknphy jknphy changed the title Enable Online tests to use Full medium as mirror [WIP] Enable Online tests to use Full medium as mirror Apr 21, 2020
@jknphy jknphy force-pushed the scenarios_mirror_using_full_medium branch 3 times, most recently from 0d18a84 to 43d3d7a Compare April 22, 2020 07:20
Copy link
Member

@rwx788 rwx788 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Test scenarios: gnome_http, gnome_self_signed_https and gnome_smb
@jknphy jknphy force-pushed the scenarios_mirror_using_full_medium branch from 43d3d7a to fdd84a6 Compare April 22, 2020 08:27
@jknphy jknphy changed the title [WIP] Enable Online tests to use Full medium as mirror Enable Online tests to use Full medium as mirror Apr 22, 2020
@jknphy jknphy merged commit fb835a8 into os-autoinst:master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants