Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement FIPS certification for gnutls #10155

Merged
merged 1 commit into from May 6, 2020
Merged

Implement FIPS certification for gnutls #10155

merged 1 commit into from May 6, 2020

Conversation

rfan1
Copy link
Contributor

@rfan1 rfan1 commented Apr 30, 2020 •
edited

Description:
SLES15SP2 FIPS certification, we need to certify gnutls and libnettle.
JIRA ID:https://jira.suse.com/browse/SLE-9520

lilyeyes
lilyeyes reviewed Apr 30, 2020
View reviewed changes
Copy link
Contributor

@lilyeyes lilyeyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@jouyingbin
Copy link
Contributor

The commit title is typo.
(X) Impliment -> Implement .

@rfan1 rfan1 changed the title Impliment FIPS certification for gnutls Implement FIPS certification for gnutls May 6, 2020
@rfan1
Copy link
Contributor Author

rfan1 commented May 6, 2020

The commit title is typo.
(X) Impliment -> Implement .

Thanks, just modified

lilyeyes
lilyeyes approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@lilyeyes lilyeyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, it looks better now :)

jouyingbin
jouyingbin approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@jouyingbin jouyingbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the more detail review, it is looking good to me now, thanks for the changes. :)

@lemon-suse lemon-suse merged commit 041bf10 into os-autoinst:master May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jouyingbin jouyingbin jouyingbin approved these changes

@lilyeyes lilyeyes lilyeyes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@rfan1 @jouyingbin @lilyeyes @lemon-suse