Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workarounds in yast2 nis mm tests #10204

Merged
merged 1 commit into from
May 12, 2020

Conversation

JRivrain
Copy link
Contributor

@JRivrain JRivrain commented May 7, 2020

It was somehow decided that we don't support auto-configuration of firewall for nis and nfs, see https://bugzilla.suse.com/show_bug.cgi?id=1083487#c36. Therefore, adding a service file to activate a button that the customer may never see does not make sense : it's a bit like testing an easter egg. Then that does not even work, as shows the next soft failure : we have to stop the firewall despite having quoted "open firewall ports". So the easter egg does not even open the right ports anyway.

Remove xml files for ypbind/serv firewall hack
@JRivrain JRivrain changed the title Remove workarounds in yast2 nis mm tests [WIP] Remove workarounds in yast2 nis mm tests May 7, 2020
Copy link
Member

@rwx788 rwx788 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked and wasn't able to find any usage of the test modules for older versions of distributions ( http://s.qa.suse.de/PsC_ ), so we can merge, once needles for SLE are merged.

Needles for openSUSE are merged now.

@JRivrain JRivrain changed the title [WIP] Remove workarounds in yast2 nis mm tests Remove workarounds in yast2 nis mm tests May 11, 2020
@jknphy
Copy link
Contributor

jknphy commented May 12, 2020

LGTM, could you please update 'related ticket'?

@rwx788
Copy link
Member

rwx788 commented May 12, 2020

LGTM, could you please update 'related ticket'?

Please, not that needles for SLES are not yet merged.

@jknphy
Copy link
Contributor

jknphy commented May 12, 2020

LGTM, could you please update 'related ticket'?

Please, not that needles for SLES are not yet merged.

I saw it, just referring to the code :) , but yes I should add it in case of doubt, LGTM sound like mergeable

@rwx788
Copy link
Member

rwx788 commented May 12, 2020

LGTM, could you please update 'related ticket'?

Please, not that needles for SLES are not yet merged.

I saw it, just referring to the code :) , but yes I should add it in case of doubt, LGTM sound like mergeable

Yeah, that message wasn't meant for you as you didn't merge =) But other reviewers can see LGTM and merge, so I tried to prevent that only. Now all needles are merged and we can proceed with PR.

@rwx788 rwx788 merged commit 03f1d89 into os-autoinst:master May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants