Disable samba module in ncurses suite #10270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add yaml file for isolated samba test
b10n1k
reviewed
May 15, 2020
| @@ -1400,7 +1400,6 @@ sub load_extra_tests_y2uitest_ncurses { | |||
| unless (is_s390x) { | |||
| loadtest "console/yast2_proxy"; | |||
| loadtest "console/yast2_vnc"; | |||
| loadtest "console/yast2_samba"; | |||
There was a problem hiding this comment.
this could be excluded based on a variable. The reason is that is will be manageable letting others knows whats going on and it will be easier to recover. What do you think?
There was a problem hiding this comment.
we could just mention in the follow-up ticket not forget to re-enable in O3 with proper schedule.
b10n1k
requested changes
May 15, 2020
rwx788
reviewed
May 15, 2020
| @@ -0,0 +1,8 @@ | |||
| name: samba_ncurses | |||
| description: > | |||
| Samba test has to be excluded from ncurses suite until resolution of bsc#1146736. This test suite is to be executed in development groups. | |||
There was a problem hiding this comment.
Nitpicking, but could you please split it in multiple lines.
rwx788
reviewed
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Samba test has to be excluded from ncurses suite until resolution of bsc#1146736 and executed in development groups.