Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main_common: Simplify some conditions; Add more unregister needles #10306

Merged
merged 3 commits into from May 26, 2020

Conversation

okurz
Copy link
Member

@okurz okurz commented May 18, 2020

Verification run:

openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/10306 https://openqa.opensuse.org/tests/1271885 SCHEDULE=tests/installation/bootloader_uefi,tests/installation/finish_desktop

opensuse-Tumbleweed-GNOME-Live-aarch64-Build20200517-gnome-live@USBboot_aarch64 -> https://openqa.opensuse.org/t1272274

@okurz okurz changed the title main_common: Simplify some conditions main_common: Simplify some conditions; Add more unregister needles May 19, 2020
@foursixnine
Copy link
Member

isn't this #10307?

@okurz
Copy link
Member Author

okurz commented May 19, 2020

hm, no. #10307 has additionally one more commit 654a243 . I could split it up differently if you prefer of course. If we would merge this PR then we simply have a single commit in #10307 left.

@foursixnine
Copy link
Member

foursixnine commented May 19, 2020

hm, no. #10307 has additionally one more commit 654a243 . I could split it up differently if you prefer of course. If we would merge this PR then we simply have a single commit in #10307 left.

Just treat all of them in a single PR but separate commits ;), for ease of the eyes of the reviewer

@okurz okurz merged commit 28272f1 into os-autoinst:master May 26, 2020
@okurz okurz deleted the enhance/simplify branch May 26, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants