Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add match_timeout at firefox launch second time to avoid needles mismatch #10369

Merged
merged 1 commit into from May 26, 2020

Conversation

jouyingbin
Copy link
Contributor

@jouyingbin jouyingbin commented May 26, 2020

The issue only can be reproduced on s390x ENV mode, and it could be the worker is too busy to respond, more likely the s390x performance problem, so it can be reproduced while job is too busy.

  1. Add match_timeout => 360 at firefox launch second time
  2. Avoid the mismatch while the worker is too busy to respond

@jouyingbin jouyingbin changed the title Add timeout at firefox launch second time to avoid needles mismatch Add match_timeout at firefox launch second time to avoid needles mismatch May 26, 2020
1. Add match_timeout => 360 at firefox launch second time
2. Avoid the mismatch while worker is too busy to response
Copy link
Contributor

@rfan1 rfan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lilyeyes lilyeyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the changes.

@coolgw coolgw merged commit 82a2c6c into os-autoinst:master May 26, 2020
@jouyingbin jouyingbin deleted the firefox_nss_timeout branch May 26, 2020 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants