Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt salt.tar.gz to the latest yast2-configuration-management changes #10380

Merged
merged 2 commits into from
May 27, 2020

Conversation

imobachgs
Copy link
Contributor

This PR updates the salt.tar.gz (which, btw, it is a TAR but it is not gzipped besides its name) to the latest changes we introduced in yast2-configuration-management 4.2.5. The main change is that now the formulas directory is composed of states and metadata directories in order to follow the same structure as SUMA Formulas.

@b10n1k
Copy link
Contributor

b10n1k commented May 26, 2020

https://openqa.suse.de/tests/4284267 VR for the PR above. and looks good

@b10n1k
Copy link
Contributor

b10n1k commented May 26, 2020

@imobachgs there is another defect in the execution. the "Running Provission" popup[0] does not close automatically as it was happening before. is something that you can take care of should we adjust the test?

[0] https://openqa.suse.de/tests/4284267#step/installation/48

@imobachgs
Copy link
Contributor Author

You are right, sorry. One of the changes we introduced in version 4.2.5 is that we honor now the report settings. So we need to set a timeout for messages. As a side note, if an error happens, the module will stick to the report settings for errors instead.

I have updated the PR. Let's see whether it is enough to make it work.

Thanks!

@b10n1k
Copy link
Contributor

b10n1k commented May 27, 2020

https://openqa.suse.de/tests/4288172#details done. All good
@rwx788 can you review and merge?

@rwx788 rwx788 merged commit ddcb9f2 into os-autoinst:master May 27, 2020
@b10n1k
Copy link
Contributor

b10n1k commented May 27, 2020

https://openqa.suse.de/tests/4288212 pass

@rwx788
Copy link
Member

rwx788 commented May 27, 2020

@imobachgs Thanks a lot for the patch!

@imobachgs imobachgs deleted the ticket-67285 branch May 27, 2020 15:02
@imobachgs
Copy link
Contributor Author

@imobachgs Thanks a lot for the patch!

You are welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants