Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable transactional update tests for zkvm #10432

Merged
merged 1 commit into from Jun 4, 2020

Conversation

JRivrain
Copy link
Contributor

@JRivrain JRivrain commented Jun 3, 2020

Test has to be adjusted for s390

@JRivrain JRivrain force-pushed the trucdeouf branch 3 times, most recently from c47b583 to 9135f93 Compare June 3, 2020 14:43
@JRivrain JRivrain changed the title [WIP] Enable transactional update tests for zkvm Enable transactional update tests for zkvm Jun 3, 2020
Fix health_check in for s390
Copy link
Contributor

@b10n1k b10n1k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO if boot/reconnect_mgmt_console.pm works it will make the schedule more transparent and we will keep clean this module, letting it do one thing and not mix it with not related code.

@JRivrain
Copy link
Contributor Author

JRivrain commented Jun 4, 2020

IMO if boot/reconnect_mgmt_console.pm works it will make the schedule more transparent and we will keep clean this module, letting it do one thing and not mix it with not related code.

No, as you can see in the test run, we call need to call reconnect_mgmt_console multiple times, for each reboot.

@rwx788
Copy link
Member

rwx788 commented Jun 4, 2020

We should find some time to improve rebooting for all the scenarios on s390x, as we have those hacks in each case where we need to handle the reboot.

@rwx788 rwx788 merged commit c41cef9 into os-autoinst:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants