Check if SUSEConnect command includes all expected addons info for migration #10452
Conversation
|
I think the condition is ok for isolate migration test from others. |
| assert_script_run "SUSEConnect --status-text | grep -v 'Not Registered'" unless get_var('MEDIA_UPGRADE'); | ||
| if (!get_var('MEDIA_UPGRADE')) { | ||
| assert_script_run "SUSEConnect --status-text | grep -v 'Not Registered'"; | ||
| services::registered_addons::full_registered_check; |
There was a problem hiding this comment.
I don't think that we have clash of names, so it should work if we just use full_registered_check. Otherwise we can skip explicit import as we call it by full name.
There was a problem hiding this comment.
I used 'full_registered_check' before, it cannot find this file. So I change to use full path
There was a problem hiding this comment.
I've checked now, and it's actually because it's not exported in the lib/services/registered_addons.pm. As you import that method, I would propose to export it properly in lib/services/registered_addons.pm
There was a problem hiding this comment.
Hi Rodion, I merge it seems early, do you think we need revert it and add this modification?
Check if SUSEConnect command includes all expected addons info
Background: Before we only check SUSEConnect -s command includes all expected addons registration information. Now we need add SUSEConnect --list-extensions and SUSEConnect --status-text command also includes all expected addon information. As we have check each addons at SUSEConnect -s command. Now we just need compare addon information between SUSEConnect -s and SUSEConnect --list-extensions & SUSEConnect --staus-text command. If those two command includes all addons which SUSEConnect -s included. We will get all expected addons information.
Verification run:https://openqa.nue.suse.com/tests/4315290#step/system_prepare/22
function case: https://openqa.nue.suse.com/tests/4315214#step/system_prepare/10