Start installer on Live CD with icon click #10519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwx788
reviewed
Jun 15, 2020
OleksandrOrlov
force-pushed
the
66355_start_installer_aarch64
branch
3 times, most recently
from
be9c0d2
to
e6f850a
Compare
OleksandrOrlov
force-pushed
the
66355_start_installer_aarch64
branch
from
e6f850a
to
eef5a45
Compare
b10n1k
reviewed
Jun 15, 2020
| if (is_aarch64) { | ||
| # On aarch64 there is sporadic issue when "Install" icon is clicked too long, | ||
| # so that context menu is called instead of opening the wizard. | ||
| x11_start_program('xdg-su -c "/usr/sbin/start-install.sh"', target_match => 'maximize'); |
There was a problem hiding this comment.
should we display a softfail here to know that this is not the expected user experience?
There was a problem hiding this comment.
There is no ticket for this, so I cannot add soft-fail here. And I'm not sure if we need ticket for this at all, as it does not look like something we can fix.
On all architectures, except aarch64, start Installer Wizard by clicking on the appropriate icon. On aarch64 use x11_start_program instead due to sporadic issue when mouse is hold too long, so that context pop-up is appeared. The decision to revert the click on icon for other architectures was made during discussion in PR#10474. Related ticket: https://progress.opensuse.org/issues/66355
OleksandrOrlov
force-pushed
the
66355_start_installer_aarch64
branch
from
eef5a45
to
5558f9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On all architectures, except aarch64, start Installer Wizard by
clicking on the appropriate icon.
On aarch64 use x11_start_program instead due to sporadic issue when
mouse is hold too long, so that context pop-up is appeared.
The decision to revert the click on icon for other architectures was
made during discussion in PR#10474.
Related ticket: https://progress.opensuse.org/issues/66355
VR: https://openqa.opensuse.org/tests/1301282