Use Negative Lookhead for /nothing provides/ #10523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@OleksandrOrlov could you be my second reviewer? |
b10n1k
force-pushed
the
67708_whitelist_log
branch
from
1f1f562
to
2b9d9b1
Compare
rwx788
reviewed
Jun 16, 2020
There was a problem hiding this comment.
LGTM, could you please adjust commit message and PR header as per https://chris.beams.io/posts/git-commit/ ? And we can merge.
|
LGTM. Could you please, change the commit message as Rodion suggested. |
Use of Negative Lookahead in the regex to filter /nothing provides/ and match all but not the one in the bug report. Then move it to be catched in the %y2log_known_errors which gives us a softfail report.
b10n1k
force-pushed
the
67708_whitelist_log
branch
from
2b9d9b1
to
9d0031f
Compare
Done. If applied, this commit will Use Negative Lookhead for /nothing provides/ |
OleksandrOrlov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of Negative Lookahead in the regex to
filter /nothing provides/ and match all but not the one in the bug report.
Then move it to be catched in the %y2log_known_errors which gives us
a softfail report.