Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve suseconnect_scc UI check #10563

Merged
merged 1 commit into from Jun 30, 2020

Conversation

Zaoliang
Copy link
Contributor

@Zaoliang Zaoliang commented Jun 23, 2020

needle match is only for Server Applications Module 15 SP2 and
Web and Scripting Module 15 SP2 without matching neither architecture,
nor the instructions to activate/deactivate

Verifications:
https://openqa.suse.de/tests/4384250#step/suseconnect_scc/15
https://openqa.suse.de/tests/4384249#step/suseconnect_scc/15
https://openqa.suse.de/tests/4384248#step/suseconnect_scc/15

@Zaoliang Zaoliang force-pushed the suseconnect_scc-202006 branch 4 times, most recently from 9fd1a60 to 7b548a4 Compare June 24, 2020 07:25
@Zaoliang Zaoliang changed the title WIP: Improve suseconnect_scc UI check Improve suseconnect_scc UI check Jun 24, 2020
@Zaoliang Zaoliang requested a review from asdil12 June 24, 2020 07:27
tests/console/suseconnect_scc.pm Outdated Show resolved Hide resolved
@Zaoliang Zaoliang force-pushed the suseconnect_scc-202006 branch 3 times, most recently from 52f0db7 to c6927bd Compare June 24, 2020 08:00
Copy link
Member

@asdil12 asdil12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please do another verification run with the new changes.

needle match is only for Server Applications Module 15 SP2 and
Web and Scripting Module 15 SP2 without matching neither architecture,
nor the instructions to activate/deactivate

verifications:
https://openqa.suse.de/tests/4384250#step/suseconnect_scc/15
https://openqa.suse.de/tests/4384249#step/suseconnect_scc/15
https://openqa.suse.de/tests/4384248#step/suseconnect_scc/15
@Zaoliang
Copy link
Contributor Author

verification tests have been updated as well.

@foursixnine foursixnine merged commit 6e81a97 into os-autoinst:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants