Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verification modules for autoyast_lvm #10657

Merged
merged 1 commit into from Jul 28, 2020

Conversation

JRivrain
Copy link
Contributor

@JRivrain JRivrain commented Jul 7, 2020

Add 3 modules in autoyast_lvm to validate autoyast profile, and look if the lvm objects are actually present and looking good after install.
Includes also a modification of vaidate_lvm to work in different scenarios.

@JRivrain JRivrain force-pushed the autoyast_lvm branch 5 times, most recently from 8fd041f to 4bf7790 Compare July 16, 2020 11:36
@JRivrain JRivrain changed the title [WIP] Add verification module for autoyast_lvm Add verification module for autoyast_lvm Jul 16, 2020
@JRivrain JRivrain changed the title Add verification module for autoyast_lvm [WIP] Add verification module for autoyast_lvm Jul 16, 2020
@JRivrain JRivrain changed the title [WIP] Add verification module for autoyast_lvm Add verification module for autoyast_lvm Jul 16, 2020
@JRivrain JRivrain changed the title Add verification module for autoyast_lvm Add verification modules for autoyast_lvm Jul 17, 2020
@jknphy
Copy link
Contributor

jknphy commented Jul 20, 2020

we have this module for lvm validation https://openqa.suse.de/tests/4428112#step/validate_lvm/9 do you have some run where we can see what is failing and if we can consider to adapt it to use it here?

@JRivrain
Copy link
Contributor Author

we have this module for lvm validation https://openqa.suse.de/tests/4428112#step/validate_lvm/9 do you have some run where we can see what is failing and if we can consider to adapt it to use it here?

Will need modifications, as it's designed for a single disk, and here we have two. Probably not so difficult to achieve.

@JRivrain JRivrain changed the title Add verification modules for autoyast_lvm [WIP] Add verification modules for autoyast_lvm Jul 21, 2020
@JRivrain JRivrain force-pushed the autoyast_lvm branch 5 times, most recently from c230f5b to dc73964 Compare July 22, 2020 16:24
@JRivrain
Copy link
Contributor Author

So, I adapted autoyast_lvm to work with more than one Physical Volume, and more than one Volume Group. The modifications can appear a bit overkill, but I think it's what it takes to make that module work for different LVM scenarios. I kept also the other module, verify_lvm_parition, to validate that the partitions created reflect what is in the profile. I did not add test data for the latter, as I think the current thing does the job, but I could change this if requested.

tests/autoyast/verify_lvm_partitions.pm Outdated Show resolved Hide resolved
tests/autoyast/verify_lvm_partitions.pm Show resolved Hide resolved
tests/console/validate_lvm.pm Outdated Show resolved Hide resolved
tests/console/validate_lvm.pm Outdated Show resolved Hide resolved
tests/console/validate_lvm.pm Outdated Show resolved Hide resolved
@JRivrain
Copy link
Contributor Author

JRivrain commented Jul 24, 2020

Rewrote it, I had over-complicated the thing to an incredible... extent. I realized I just need to sum-up the free PE and total PE, regardless of the VGs.

@JRivrain JRivrain changed the title [WIP] Add verification modules for autoyast_lvm Add verification modules for autoyast_lvm Jul 24, 2020
Copy link
Member

@rwx788 rwx788 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rwx788 rwx788 merged commit ab33cc1 into os-autoinst:master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants