New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add verification modules for autoyast_lvm #10657
Conversation
8fd041f
to
4bf7790
Compare
we have this module for lvm validation https://openqa.suse.de/tests/4428112#step/validate_lvm/9 do you have some run where we can see what is failing and if we can consider to adapt it to use it here? |
Will need modifications, as it's designed for a single disk, and here we have two. Probably not so difficult to achieve. |
c230f5b
to
dc73964
Compare
So, I adapted autoyast_lvm to work with more than one Physical Volume, and more than one Volume Group. The modifications can appear a bit overkill, but I think it's what it takes to make that module work for different LVM scenarios. I kept also the other module, verify_lvm_parition, to validate that the partitions created reflect what is in the profile. I did not add test data for the latter, as I think the current thing does the job, but I could change this if requested. |
b0b027a
to
7d8b4f3
Compare
Rewrote it, I had over-complicated the thing to an incredible... extent. I realized I just need to sum-up the free PE and total PE, regardless of the VGs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add 3 modules in autoyast_lvm to validate autoyast profile, and look if the lvm objects are actually present and looking good after install.
Includes also a modification of vaidate_lvm to work in different scenarios.
autoyast_lvm: http://waaa-amazing.suse.cz/tests/12728
cryptlvm: http://waaa-amazing.suse.cz/tests/12731