Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schedule for autoyast_lvm and autoyast_tftp #10672

Merged
merged 1 commit into from Jul 13, 2020

Conversation

OleksandrOrlov
Copy link
Contributor

@OleksandrOrlov OleksandrOrlov commented Jul 9, 2020

The PR adds the common schedule for autoyast_lvm and autoyast_tftp. All the variables are specified in Job Group Settings.

Job Group Settings: https://gitlab.suse.de/qsf-y/qa-sle-functional-y/-/merge_requests/237

VR:

Copy link
Member

@rwx788 rwx788 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So do we merge it this way? Because @JRivrain works on validation module for autoyast_lvm which will break this concept and we will have to have 2 different schedules.

@OleksandrOrlov
Copy link
Contributor Author

@rwx788 Ok. I've created two separate schedules.

Copy link
Member

@rwx788 rwx788 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jknphy jknphy self-requested a review July 13, 2020 13:03
@rwx788 rwx788 merged commit 84c738d into os-autoinst:master Jul 13, 2020
@OleksandrOrlov OleksandrOrlov deleted the fix_autoyast_lvm branch July 13, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants