Add yaml schedule for minimal+base for PowerVM #10691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OleksandrOrlov
force-pushed
the
68733_minimal_base_pvm
branch
2 times, most recently
from
8167c5a
to
a36efdf
Compare
jknphy
reviewed
Jul 14, 2020
There was a problem hiding this comment.
LGTM other than we could have reused https://github.com/os-autoinst/os-autoinst-distri-opensuse/blob/master/schedule/yast/minimal%2Bbase/minimal%2Bbase%40yast-s390x.yaml with only one module difference adding just one conditional, but it is already really spread, so just asking your opinion if it worth it not?
OleksandrOrlov
force-pushed
the
68733_minimal_base_pvm
branch
from
a36efdf
to
cb0dcd0
Compare
|
I was thinking to unify the remote backend files, but that also works, it is the same effort. Thanks for the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds the yaml schedule for minimal+base for PowerVM.