Enable yast2_lan_device_settings for svirt backend #10713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OleksandrOrlov
changed the title
sofiasyria
force-pushed
the
ac67603
branch
2 times, most recently
from
a90b76b
to
62516ed
Compare
b10n1k
reviewed
Jul 17, 2020
| $is_set_in_etc_host->($static_hostname) or die qq{Static hostname "$static_hostname" was not written to /etc/hosts file!\n}; | ||
|
|
||
| open_yast2_lan(); | ||
| for (1 .. 2) { send_key "tab" } # move to device list |
There was a problem hiding this comment.
@sofiasyria Can you run VR against non-s390x to observe the behaviour! i have the impression that this could be moved later in the code. i think you can move some part later in the test instead of open and close again the yast2_lan. But i would like to see a VR first.
There was a problem hiding this comment.
But Sofia did not change that part of code, so it should work as before. Not sure that we need to change something here in scope of the PR.
There was a problem hiding this comment.
About open and close I agree that it's not optimal, but this is not my code, it's green just because of the new indentation. I just added a condition that includes old code.
sofiasyria
changed the title
sofiasyria
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slight modifications in yast2_lan_device_setting, in order for it to run on svirt backend.
Modification of YAML schedules.
yast2_lan_device_settings-device-setup-pop-up-20200715
yast2_lan-add-vlan-selected-20200715
yast2_lan-vlan-added--20200715
yast2_lan-vlan-selected-20200715
yast2_lan-static-ip-address-set-20200715
yast2_lan_duplicate_ip-20200717