Test suite for iSCSI server and client

[dzedro]

Multimachine testsuites, server test creates iscsi target and client test uses it
server: http://10.100.98.90/tests/1060
client: http://10.100.98.90/tests/1061

I just copied wait.pm from supportserver

[okurz]

We would like to use less sleep. Can you try to replace all "sleep"? I guess wait_still_screen works here.

[dzedro]

sure, I will try it

[okurz]

see inline comments

[okurz]

another point: I did not see you enabling the test in the main.pm, only in sle12 branch. openSUSE distributions should have no problem running iSCSI tests, please check.

[dzedro]

Updated, it should work also for openSUSE, tested a bit Tumbleweed, but have to create all needles and check if shortcuts fit.

server: http://10.100.98.90/tests/1139/modules/iscsi_server/steps/26
client: http://10.100.98.90/tests/1140/modules/iscsi_client/steps/24

[okurz]

+1 to me, let others have a look, too

[dzedro]

SLES
server: http://10.100.98.90/tests/1176
client: http://10.100.98.90/tests/1177

Tumbleweed:
server: http://10.100.98.90/tests/1174
client: http://10.100.98.90/tests/1175

[okurz]

@sysrich please take a look

[nilxam]

I have no idea why you're trying to set_var() here, but it won't work - not saved to vars.json...save_vars() already passed.

[dzedro]

Hmm, it did work and it is also in vars.json

Tumbleweed:
server: http://10.100.98.90/tests/1174
client: http://10.100.98.90/tests/1175

[nilxam]

ok, you're right, I'm outdated, even load_vars() was in start_vm, it's 2016!

[aaannz]

bmwqemu::vars will be updated anyway so I think test will work. Only thing is that you won't see this variable set in webui, which will bite @dzedro in few months.
Or am I missing something?

[coolo]

We have other variables that follow other variables - without them showing in the job_settings. I don't see the problem. But I would indeed factor this out of the load_ functions and put them in front of the save_vars to make this variable dependency more clearer

[okurz]

I agree but how do you track ideas like this? Do you rely on others to grab your suggestion and go ahead and if nothing happens you do it or if nobody cares it wil be forgotten and it might not have been that important after all?

[coolo]

I just plant my suggestion into the brain of the next one to touch main.pm and it will work out - if not, I might be the one after that one ;)

[okurz]

good to know, I don't need to neither do it then nor remember nor create a ticket :-)

[okurz]

ok, no more comments from others so I accept this