Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate ftp mirror repo in remote_ssh_target_ftp scenario #10768

Merged
merged 2 commits into from
Aug 4, 2020

Conversation

b10n1k
Copy link
Contributor

@b10n1k b10n1k commented Jul 31, 2020

Schedule validate_mirror_repos in remote_ssh_target_ftp

Schedule validate_mirror_repos in remote_ssh_target_ftp
Copy link
Member

@rwx788 rwx788 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine, but your VR has failed with an error. Could you please take a look? Maybe module will require more changes.

@b10n1k
Copy link
Contributor Author

b10n1k commented Aug 3, 2020

Changes look fine, but your VR has failed with an error. Could you please take a look? Maybe module will require more changes.

If you take a look on the progress ticket i have reported a bug for it. in short the URI differs

@rwx788
Copy link
Member

rwx788 commented Aug 3, 2020

Changes look fine, but your VR has failed with an error. Could you please take a look? Maybe module will require more changes.

If you take a look on the progress ticket i have reported a bug for it. in short the URI differs

Progress ticket url is wrong one (https://progress.opensuse.org/issues/59220) please, update the description with correct one.

@rwx788
Copy link
Member

rwx788 commented Aug 3, 2020

Changes look fine, but your VR has failed with an error. Could you please take a look? Maybe module will require more changes.

If you take a look on the progress ticket i have reported a bug for it. in short the URI differs

I guess problem is that we type directory with leading '/', so I don't think it's a product bug. I believe we should fix the test not to put leading slash before the directory or at least adjust the expectations.

@b10n1k
Copy link
Contributor Author

b10n1k commented Aug 3, 2020

I added another commit to fix this. I have updated the VR at the top and additional VR for last commit http://aquarius.suse.cz/tests/2960 against remote_vnc

Copy link
Member

@rwx788 rwx788 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rwx788 rwx788 merged commit 4afa31f into os-autoinst:master Aug 4, 2020
@b10n1k b10n1k deleted the 69220_validate_ftp_mirror branch August 24, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants