Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox: Add wait time and define timeout due to blinking cursor #10800

Merged
merged 1 commit into from
Aug 10, 2020
Merged

firefox: Add wait time and define timeout due to blinking cursor #10800

merged 1 commit into from
Aug 10, 2020

Conversation

dzedro
Copy link
Contributor

@dzedro dzedro commented Aug 9, 2020 •
edited
Loading

okurz
okurz reviewed Aug 9, 2020
View reviewed changes
Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is a blinking cursor you can use the parameter no_wait as defined in https://github.com/os-autoinst/os-autoinst/blob/master/testapi.pm#L665

@dzedro
Copy link
Contributor Author

dzedro commented Aug 9, 2020

If there is a blinking cursor you can use the parameter no_wait as defined in https://github.com/os-autoinst/os-autoinst/blob/master/testapi.pm#L665

I guess no_wait is a bit misleading, it adds short wait time before it starts to check screen, not sure how it would help with blinking cursor.

@dzedro dzedro added the Ready Ready for review label Aug 9, 2020
@okurz
Copy link
Member

okurz commented Aug 10, 2020

I guess no_wait is a bit misleading, it adds short wait time before it starts to check screen, not sure how it would help with blinking cursor.

Do you mean https://github.com/os-autoinst/os-autoinst/blob/52434c7ca31c69b85342e7061255c80dbd04678f/isotovideo#L335 ? This is not "short wait time before" but ensuring that we check effectively 10x a second, not just once. This is meant for the cases of when the screen is changing on a regular base and checking just once every second can mean that we always look at the wrong time. If for example the needle includes the cursor but every time we look we miss it because the cursor blinks e.g. every 200ms we miss it. With no_wait there is a check 10x a second which should be "often enough" to catch these cases

@dzedro
Copy link
Contributor Author

dzedro commented Aug 10, 2020

I guess no_wait is a bit misleading, it adds short wait time before it starts to check screen, not sure how it would help with blinking cursor.

Do you mean https://github.com/os-autoinst/os-autoinst/blob/52434c7ca31c69b85342e7061255c80dbd04678f/isotovideo#L335 ? This is not "short wait time before" but ensuring that we check effectively 10x a second, not just once. This is meant for the cases of when the screen is changing on a regular base and checking just once every second can mean that we always look at the wrong time. If for example the needle includes the cursor but every time we look we miss it because the cursor blinks e.g. every 200ms we miss it. With no_wait there is a check 10x a second which should be "often enough" to catch these cases

I was looking at this https://github.com/os-autoinst/os-autoinst/blob/master/testapi.pm#L710, but I misunderstood it.
Anyway how should no_wait help wait_still_screen not wait full default timeout due to always changing screen ?

@dzedro dzedro merged commit c3bc57d into os-autoinst:master Aug 10, 2020
@dzedro dzedro deleted the firefox branch August 10, 2020 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okurz okurz okurz left review comments

Assignees
No one assigned
Labels
Ready Ready for review
Projects
None yet
Milestone
No milestone
2 participants
@dzedro @okurz