Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation to cryptlvm+cancel_existing scenario #10801

Merged

Conversation

b10n1k
Copy link
Contributor

@b10n1k b10n1k commented Aug 10, 2020

The https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/10744/files#diff-02e3850fe36faeb4fe731d27cdf08818
returns an error code 4 when the encryption is not activated. Passing the proceed_on_failure so we can run assertions even
if the script_output gets the error code.

@b10n1k b10n1k force-pushed the 69040_validation_cryptlvm_cancel_existing branch 2 times, most recently from 1a02e72 to f5bc12f Compare August 10, 2020 14:52
@b10n1k b10n1k marked this pull request as ready for review August 10, 2020 18:00
The https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/10744/files#diff-02e3850fe36faeb4fe731d27cdf08818
returns an error code 4 when the encryption is not activated. Passing the proceed_on_failure so we can run assertions even
if the script_output gets the error code.
@b10n1k b10n1k force-pushed the 69040_validation_cryptlvm_cancel_existing branch from f5bc12f to d6233a4 Compare August 12, 2020 13:47
Copy link
Member

@rwx788 rwx788 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, well done!

@rwx788 rwx788 merged commit 1ca048d into os-autoinst:master Aug 13, 2020
@b10n1k b10n1k deleted the 69040_validation_cryptlvm_cancel_existing branch August 24, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants