Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate DUD dynamically before installation #11032

Merged
merged 1 commit into from Sep 21, 2020
Merged

Generate DUD dynamically before installation #11032

merged 1 commit into from Sep 21, 2020

Conversation

jknphy
Copy link
Contributor

@jknphy jknphy commented Sep 18, 2020 •
edited

See poo#70726
MR in job groups: https://gitlab.suse.de/qsf-y/qa-sle-functional-y/-/merge_requests/279
Verification run: generated_dud & dud_development_tools_dev

Notes:

@jknphy jknphy changed the title Generate DUD dynamically before installation [WIP] Generate DUD dynamically before installation Sep 18, 2020
b10n1k
b10n1k reviewed Sep 18, 2020
View reviewed changes
lib/autoyast.pm Outdated Show resolved Hide resolved
b10n1k
b10n1k reviewed Sep 18, 2020
View reviewed changes
Copy link
Contributor

@b10n1k b10n1k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my comments are not requests for changes FYI

@jknphy jknphy force-pushed the generate_dud branch 14 times, most recently from 3260508 to ee056e9 Compare September 21, 2020 11:10
@jknphy jknphy changed the title [WIP] Generate DUD dynamically before installation Generate DUD dynamically before installation Sep 21, 2020
rwx788
rwx788 reviewed Sep 21, 2020
View reviewed changes
Copy link
Member

@rwx788 rwx788 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per comment from Santi, please, rebase and it should fix CI.

rwx788
rwx788 approved these changes Sep 21, 2020
View reviewed changes
Copy link
Member

@rwx788 rwx788 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jknphy jknphy merged commit fbe4248 into os-autoinst:master Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b10n1k b10n1k b10n1k left review comments

@rwx788 rwx788 rwx788 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jknphy @b10n1k @rwx788