Add needles match in FIPS_ENV_MODE and remove hotkey #11076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jouyingbin
force-pushed
the
firefox_env_fips
branch
from
d43d7ba
to
4f78634
Compare
lemon-suse
reviewed
Sep 25, 2020
1. Remvoe alt-shift-f hotkey usage 2. Add needles match in FIPS_ENV_MODE to enable FIPS 3. Add match_timeout in second launch 4. Add needles match the firefox close tab
jouyingbin
force-pushed
the
firefox_env_fips
branch
from
4f78634
to
ecc9dc6
Compare
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The PR is going to fix the firefox_nss Needles match and 3-key combined hotkey fail problem for the new firefox version in s390x ENV mode and also the launch firefox fail and quit_firefox fail in aarch64 ENV mode randomly.
Related ticket:
https://progress.opensuse.org/issues/71458
https://progress.opensuse.org/issues/71866
Needles: 2 Needles are merged in O.S.D.
Verification run:
https://openqa.suse.de/tests/4729682 (15SP3 B44.1 on x86_64 - ENV mode)
https://openqa.suse.de/tests/4729683 (15SP3 B44.1 on x86_64 - Kernel mode)
https://openqa.suse.de/tests/4729964 (15SP3 B44.1 on s390x - ENV mode)
https://openqa.suse.de/tests/4729665 (15SP3 B44.1 on s390x - Kernel mode)
https://openqa.suse.de/tests/4729927 (15SP3 B44.1 on aarch64 - ENV mode)
https://openqa.suse.de/tests/4729685 (15SP3 B44.1 on aarch64 - Kernel mode)
https://openqa.suse.de/tests/4729688 (QAM test on 15 SP2 Updates)