Make sure terraform command is canceled #11105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelgrifalconi
force-pushed
the
terraformAzure
branch
4 times, most recently
from
28b853f
to
faa8d71
Compare
michaelgrifalconi
changed the title
|
Hey @pdostal can you have a look? Thank you! |
pdostal
reviewed
Oct 2, 2020
pdostal
reviewed
Oct 2, 2020
Comment on lines
+382
to
+387
| if (is_serial_terminal()) { | ||
| type_string(qq(\c\\)); # Send QUIT signal | ||
| } | ||
| else { | ||
| send_key('ctrl-\\'); # Send QUIT signal | ||
| } |
There was a problem hiding this comment.
As those lines are twice the same they can be a subroutine. But it's a minor priority suggestion 👍
There was a problem hiding this comment.
a grep shows:
os-autoinst-distri-opensuse> grn '\\c\\\\'
lib/publiccloud/azure.pm:226: type_string(qq(\c\\));
lib/publiccloud/provider.pm:382: type_string(qq(\c\\)); # Send QUIT signal
lib/publiccloud/provider.pm:440: type_string(qq(\c\\)); # Send QUIT signal
tests/kernel/virtio_console_long_output.pm:65: type_string(qq(\c\\)); # Send QUIT signal
The last one seems to be for virtio_console so no change needed. But the one in azure.pm might hit your case as well, WDYT?
There was a problem hiding this comment.
Shouldn't hurt to patch also azure.pm, you are right. I just updated my commit and started a new run https://openqa.suse.de/tests/4772971#details
pdostal
approved these changes
Oct 2, 2020
when a test is using VNC instead of serial console https://progress.opensuse.org/issues/69952
michaelgrifalconi
force-pushed
the
terraformAzure
branch
from
faa8d71
to
d7ae317
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure terraform command is correctly canceled after timeout
Full work log:
Changed "lib/publiccloud/provider.pm" to make it easier to reproduce
From "use constant TERRAFORM_TIMEOUT => 17 * 60;"
To "use constant TERRAFORM_TIMEOUT => 2 * 60;"
Reproduced issue on run: https://openqa.suse.de/tests/4749425#step/ssh_interactive_init/51
Error on log: "No map for '�' at /usr/lib/os-autoinst/consoles/VNC.pm line 741."
Try to fix with change on "lib/publiccloud/provider.pm"
From "type_string(qq(\c\));"
To "type_string("\cC");"
Still same error: "No map for '�' at /usr/lib/os-autoinst/consoles/VNC.pm line 741."
Turns out, "ssh_interactive_init" is running on VNC and "type_string(\cC||\c\)" are meant for serial only.
Added a check for serial terminal on "provider.pm" not if fails as expected:
https://openqa.suse.de/tests/4751094
Changed back to "use constant TERRAFORM_TIMEOUT => 17 * 60;"
One last run without code to force reproducing the issue: https://openqa.suse.de/tests/4759779