Adjust lvm+RAID1 tests for the UI changes in the Expert Partitioner #11448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwx788
force-pushed
the
libyui
branch
29 times, most recently
from
60ff0d8
to
084d738
Compare
rwx788
force-pushed
the
libyui
branch
3 times, most recently
from
6ba22a8
to
ec7343b
Compare
rwx788
force-pushed
the
libyui
branch
2 times, most recently
from
f0dc117
to
6821781
Compare
jknphy
approved these changes
Nov 26, 2020
rwx788
force-pushed
the
libyui
branch
3 times, most recently
from
15d9c0b
to
1591e79
Compare
added 3 commits
November 27, 2020 09:08
On svirt we cannot know ip address from the hypervisor, so have to wait till installer boots, and get ip address from there. We use bridge netwroking there, so that ip address is accessible from the worker.
Uniting test data for sles and openSUSE, as it's same and reuse it in both schedules.
added 7 commits
November 27, 2020 11:13
We have different test data for SLE 12 as partitioning was different there, but for other scenarios we have same setup which differs only for the backends, so name should reflect that this is universal data.
On xen-pv we have 5 disks available and should not touch /dev/xvda disk, so we cannot use solution to clone one disk setup to all. We already have data where to clone partitioning, so implementing method to define target disks.
We have a bug in REST API and menu items do not get enabled, when item in the table is selected. So applying workaround for now and will revert this commit once it's available.
We have same steps in raid_gpt and setup_raid1_lvm, so moving common part to the Expert Partitioner controller.
In encrypted_full_lvm and lvm+raid1 we have same code for the configuration of the lvm, which we can move to the controller library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use libyui REST API to deal with changes in the UI. This PR also contains parts to setup environment for svirt backends, including hyper-v.
See poo#77767.
Verification runs
Note: failed scenarios expose https://bugzilla.suse.com/show_bug.cgi?id=1178832