Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ntp_client: Wait for 4 sources which responded to request #11449

Merged
merged 1 commit into from Nov 24, 2020
Merged

ntp_client: Wait for 4 sources which responded to request #11449

merged 1 commit into from Nov 24, 2020

Conversation

dzedro
Copy link
Contributor

@dzedro dzedro commented Nov 20, 2020 •
edited

To avoid '503 No such source error' when running chronyc sources while
chronyc is resolving sources and wait for response from 4 sources by default

@Vogtinator
Copy link
Member

That seems like a product bug to me. If openQA finds that chrony is unacceptably slow, it should be fixed.

@dzedro
Copy link
Contributor Author

dzedro commented Nov 20, 2020 •
edited

That seems like a product bug to me. If openQA finds that chrony is unacceptably slow, it should be fixed.

We check chronyc sources immediately after the daemon is started. The resolving and syncing of sources takes some time, especially when it's resolving and syncing ntp server on another side of globe.
ntp_client test take up to 11 seconds on SLE, I don't know but executing approx. 15 simple commands while one of them is resolving and syncing up to 16 servers, possibly with high delay, in less than 11 seconds is IMO not slow.

@Vogtinator
Copy link
Member

What seems odd to me is that chronyc sources shows some valid sources and then prints 503 No such source.

Maybe that happens when one of the sources it uses is not working properly, which can happen randomly?
IMO that would be a bug in chrony, and would probably happen with a lower maxdelay as well.

@dzedro
Copy link
Contributor Author

dzedro commented Nov 20, 2020 •
edited

Screenshot_2020-11-20_12-12-59

I could reproduce the 503 No such source just by spamming chronyc sources after chronycd restart with maxdelay.
I added wait loop and will open bug for it.

http://10.100.12.155/tests/16982#step/ntp_client/46

@dzedro dzedro changed the title ntp_client: Add maxdelay on ntp pool in chrony.conf ntp_client: Wait for 4 sources which responded to request Nov 20, 2020
@dzedro
Copy link
Contributor Author

dzedro commented Nov 20, 2020

I could reproduce the fail on SLE 15-SP2, 15-SP1 but also on TW, but this issue will most likely never happen on openSUSE because chrony is used by default and running since boot.

@Vogtinator
Copy link
Member

On SLE, chrony should also be running on boot. Or is time synchronization disabled there?

@dzedro
Copy link
Contributor Author

dzedro commented Nov 20, 2020

On SLE, chrony should also be running on boot. Or is time synchronization disabled there?

chronyd.service is not enabled

@Vogtinator
Copy link
Member

Ok. Once you have a product bug reported, please mention it in a comment next to the workaround

@dzedro
Copy link
Contributor Author

dzedro commented Nov 20, 2020

Added https://bugzilla.suse.com/show_bug.cgi?id=1179022

@dzedro
ntp_client: Wait for 4 sources which responded to request on SLE
6eafcc9 
To avoid '503 No such source error' on SLE when running chronyc sources while
chronyc is resolving sources and wait for response from 4 sources

https://bugzilla.suse.com/show_bug.cgi?id=1179022
@dzedro dzedro merged commit c580c56 into os-autoinst:master Nov 24, 2020
@dzedro dzedro deleted the ntp branch November 24, 2020 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dzedro @Vogtinator