Adjust modify_existing_partition to the UI chnages in the Expert Partitioner #11531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fyi: #11501 merged. In order to pass Travis CI I needed to create base class for warnings at the end to avoid error due to duplicated code. |
Thans, I will rebase and do some refactoring not to have multiple methods for resizing. Cheers. |
rwx788
force-pushed
the
libyui
branch
2 times, most recently
from
3f04f09
to
c8a9f74
Compare
added 6 commits
December 2, 2020 11:54
When partition is selected, there is Edit button, which opens editing dialog.
In the new UI partitions are displayed in the table, so selecting it there.
We need libyui-rest-api v. 0.5.11 with the fix.
Implementing override for resize_partition_on_gpt_disk and edit_partition_on_gpt_disk in the expert partitioner controller.
rwx788
force-pushed
the
libyui
branch
5 times, most recently
from
7186e5d
to
2d0e930
Compare
|
LGTM |
We have structure for adding new partitions, which we can fully reuse to modiy them to have it consistent. The only missing item will be partition name for editing, as we need to select it.
rwx788
force-pushed
the
libyui
branch
2 times, most recently
from
9ec4b00
to
696c51d
Compare
After introducing changes to the validate_modify_existing_partition module, we have to change the format of the old test to pass validation, even though this will be a bit of duplication, as this data is not used for patitioning itself.
added 2 commits
December 3, 2020 12:16
We still don't have version 0.5.11 of the libyui, where this issue is fixed. Separaring workaround in a separate commit to simplify reverting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We continue fixing tests using libyui REST API.
This PR uses commits from #11501 and we can extract common part from there.
See poo#78097.
Verification runs