Test warnings in Expert Partitioner when too small root, /boot/zipl and PReP are used #11763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
OleksandrOrlov
commented
Jan 14, 2021
•
OleksandrOrlov
commented
- Related ticket: https://progress.opensuse.org/issues/80840
- Verification runs:
- SLE: https://openqa.suse.de/tests/overview?build=124.5_oorlov&groupid=96&distri=sle&version=15-SP3
- opensuse: https://openqa.opensuse.org/tests/1588622
added 2 commits
January 14, 2021 17:12
The commit adds test module to check that the appropriate warning message appears when PReP boot partition is too small on ppc64le. The test is also scheduled for other architectures to verify that adding the PReP boot partition is processed correctly even if the system does not require it.
The commit adds test module to check that the appropriate warning message appears when /boot/zipl is too small on s390x. The test is also scheduled on other architectures to verify that adding /boot/zipl partition is processed correctly even if the system does not require it.
OleksandrOrlov
force-pushed
the
btrfs_warnings
branch
from
902ee4c
to
135716d
Compare
The commit adds test module to check that the appropriate message appears when root partition is too small.
OleksandrOrlov
force-pushed
the
btrfs_warnings
branch
from
135716d
to
c6e3a83
Compare
jknphy
reviewed
Jan 15, 2021
jknphy
reviewed
Jan 15, 2021
|
In the first comment, let's delete the template line so the PR will not be taken as WIP by mistake (like is some draft or something). I fell into that :) |
As all the warnings for missing boot are same, there is no need to duplicate the warning messages in several keys.
OleksandrOrlov
force-pushed
the
btrfs_warnings
branch
from
87ca07b
to
dd3addd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.