Remove if statement with workaround for bsc#1156047 #11767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That is a verification run without the if statement: https://openqa.opensuse.org/tests/1589601# |
rwx788
reviewed
Jan 19, 2021
There was a problem hiding this comment.
Change itself looks fine, but could you please adjust commit message, so it explains the change better ? See https://chris.beams.io/posts/git-commit/
I would even squash both commits in one and state something like Remove workaround for bsc#1156047.
Sarah-Kriesch
changed the title
|
We made the decision to remove the if statement completely. You are allowed to merge it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SoftFailed is required code. So the record_soft_fail has to be brought back.