New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement role/formatting/mounting/encryption in libyui #11820
Conversation
3e23c0b
to
6906d80
Compare
lib/Installation/Partitioner/LibstorageNG/v4_3/FormatMountOptionsPage.pm
Outdated
Show resolved
Hide resolved
lib/Installation/Partitioner/LibstorageNG/v4_3/PartitionFormatMountOptionsPage.pm
Outdated
Show resolved
Hide resolved
6906d80
to
353e824
Compare
lib/Installation/Partitioner/LibstorageNG/v4_3/PartitionFormatMountOptionsPage.pm
Outdated
Show resolved
Hide resolved
364516f
to
c1f443f
Compare
9b483a9
to
94329fa
Compare
94329fa
to
3945776
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just couple of minor points. You have tons of VRs, nevertheless, I would still ask if you have checked that none of the tests of SLE15 QR images use changed test data.
lib/Installation/Partitioner/LibstorageNG/v4_3/AbstractSizePage.pm
Outdated
Show resolved
Hide resolved
lib/Installation/Partitioner/LibstorageNG/v4_3/FormatMountOptionsPage.pm
Outdated
Show resolved
Hide resolved
3945776
to
bb4d2c6
Compare
Comparing with previous code there are really few changes (just for uniformity), thin-pool and efi-boot, I think those are not used, but in the worst case (I cannot check osd now seems down) it would require minimum changes to previous versions without the need to duplicate yaml files. |
Covers role selection, formatting, mounting, encryption when adding partitions, resizing, editing or adding logical volumes.
bb4d2c6
to
973a9c5
Compare
As we got build today, which is not snapshot one, let's merge it and see changes in the latest build. |
See poo#81042