Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement role/formatting/mounting/encryption in libyui #11820

Merged
merged 3 commits into from Jan 29, 2021

Conversation

jknphy
Copy link
Contributor

@jknphy jknphy commented Jan 21, 2021

See poo#81042

@jknphy jknphy force-pushed the formatting_option_page branch 10 times, most recently from 3e23c0b to 6906d80 Compare January 22, 2021 06:23
@jknphy jknphy changed the title Implement role/formatting/mounting/encryption in libyui WIP: Implement role/formatting/mounting/encryption in libyui Jan 26, 2021
@jknphy jknphy force-pushed the formatting_option_page branch 14 times, most recently from 364516f to c1f443f Compare January 28, 2021 08:19
@jknphy jknphy force-pushed the formatting_option_page branch 6 times, most recently from 9b483a9 to 94329fa Compare January 28, 2021 09:18
@jknphy jknphy changed the title WIP: Implement role/formatting/mounting/encryption in libyui Implement role/formatting/mounting/encryption in libyui Jan 28, 2021
Copy link
Member

@rwx788 rwx788 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just couple of minor points. You have tons of VRs, nevertheless, I would still ask if you have checked that none of the tests of SLE15 QR images use changed test data.

@jknphy
Copy link
Contributor Author

jknphy commented Jan 28, 2021

Looks good, just couple of minor points. You have tons of VRs, nevertheless, I would still ask if you have checked that none of the tests of SLE15 QR images use changed test data.

Comparing with previous code there are really few changes (just for uniformity), thin-pool and efi-boot, I think those are not used, but in the worst case (I cannot check osd now seems down) it would require minimum changes to previous versions without the need to duplicate yaml files.

Covers role selection, formatting, mounting, encryption when
adding partitions, resizing, editing or adding logical volumes.
@rwx788
Copy link
Member

rwx788 commented Jan 29, 2021

As we got build today, which is not snapshot one, let's merge it and see changes in the latest build.

@rwx788 rwx788 merged commit edce444 into os-autoinst:master Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants