Use only libyui REST API to setup raid #12017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 24, 2021 09:52
We have used old implementation to select devices for the RAID, and select raid type. To be consistent and move in the direction of having full installation using REST API, we rewrite missing parts. See [poo#88780](https://progress.opensuse.org/issues/88780).
Another step in migrating from screen based automation to REST API controlled installations. See [poo#88780](https://progress.opensuse.org/issues/88780).
rwx788
force-pushed
the
restapi
branch
2 times, most recently
from
179e639
to
f5aa4c1
Compare
added 2 commits
February 24, 2021 10:20
Those schedule are not used anymore, as gpt became default partition table type. Removing, to keep directories clean. Also module itself is not used anymore, so removing it too.
Previously we would rely on the indexes of the devices and assumptions on the order. With REST API we can select expected devices by its name and not index in the table. See [poo#88780](https://progress.opensuse.org/issues/88780).
rwx788
force-pushed
the
restapi
branch
3 times, most recently
from
4e5dfb9
to
f81cee4
Compare
rwx788
changed the title
We migrate to libyui REST API, so following changes were required: * chunk_size value was 64, but in combobox we have 64KiB * instead of selecting devices using step, selecting by name now
`No` is special keyword in YAML, and is treated as a boolean value by default. In our case we need it to be a string.
Fixes validation error: schedule/qam/common/mau-systemd.yaml 12:2 warning missing starting space in comment (comments) 15:2 warning missing starting space in comment (comments)
Implementing method to get table content, which we haven't implemented as there was no need so far. In JSON we have array of items, where labels key stores text values visible in the table.
rwx788
force-pushed
the
restapi
branch
2 times, most recently
from
4a65f85
to
2fc0ab1
Compare
added 2 commits
February 24, 2021 16:57
On aarch64 we can see that sometimes, UI doesn't react on the event properly and we miss adding devices. This happens due to multithreaded nature of the qt and UI is still processing some events when we trigger actions, which causes instabilities on slow platforms. This issue will be addressed properly on the server side, but not to get
Adding missing method for the radiobutton control to check the state of the control using REST API.
|
LGTM, good choice regarding fixing expectation for RAID devices to be added instead of using an step to select them. |
|
As we are going to have another candidate build on Monday, let's wait before merging not to introduce risks of breakages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have used old implementation to select devices for the RAID, and
select raid type. To be consistent and move in the direction of having
full installation using REST API, we rewrite missing parts.
Now we also can be more precise on which devices we want to use.
Also, we had a bug in the code, as chunk size is not editable combobox, so now select the value which is available there.
See poo#88780.
Verification runs