-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable POM structure and libyui for firstboot #12249
Conversation
5679e5a
to
d044bf4
Compare
d044bf4
to
4f74e65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some minor things, comments or some variables to remove.
Feel free (optionally) if you want to offer more granularity, at least I see 3 commits, (1) ay profiles/schedules (2) controller/pages and other rest api stuff (3) tests. But it is not really necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very promising, couple of very minor points.
cc1bfb9
to
f30ea53
Compare
f30ea53
to
139ad57
Compare
139ad57
to
6ee97cb
Compare
6ee97cb
to
167ce7f
Compare
I agree it would be nicer, but a bit complicated at that point. Next time I'll try to be more granular. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we are good to merge and keep introduce further improvements.
https://openqa.opensuse.org/tests/1696355#next_previous This fails in TW (makes me wonder about the verification runs executed, but TW also moved from libyui 4.1 to 4.2) so, the question basically is: test bug or product bug? |
There is variable missing, we will take care of fixing this. Sorry for the noise, I'm testing the patch here: https://openqa.opensuse.org/tests/1696774 |
Thank you! I tagged three test fails with poo#89866 - if your fix/test run works, I'd appreciate you adjusting the variables as needed for all the ones tagged |
Still failing for autoyast, however if I clone it to my workstation, it works. I could not find any difference between the two, same code, same variables, same profile :'( . Anyway, not a product bug as it passed for me also in the last build: http://waaa-amazing.suse.cz/tests/15010. |
4f74e65: Enable POM structure and libyui for firstboot
Create initial POM structure
Enable libyui in both autoyast and regular firstboot tests
Introduce asserting pages with debug_label rather than with random page elements (not working yet, see https://progress.opensuse.org/issues/89638 and https://progress.opensuse.org/issues/89866)
Needles: os-autoinst/os-autoinst-needles-opensuse#716
TW-firstboot TW-fisrtboot-custom TW-firstboot-autoyast LEAP-firstboot-autoyast LEAP-firstboot
SLE-firstboot SLE-firstboot-custom SLE-firstboot-autoyast SLE-firstboot-textmode