Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable POM structure and libyui for firstboot #12249

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

JRivrain
Copy link
Contributor

@JRivrain JRivrain commented Apr 8, 2021

4f74e65: Enable POM structure and libyui for firstboot

Create initial POM structure
Enable libyui in both autoyast and regular firstboot tests
Introduce asserting pages with debug_label rather than with random page elements (not working yet, see https://progress.opensuse.org/issues/89638 and https://progress.opensuse.org/issues/89866)

Needles: os-autoinst/os-autoinst-needles-opensuse#716

Copy link
Contributor

@jknphy jknphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor things, comments or some variables to remove.

Feel free (optionally) if you want to offer more granularity, at least I see 3 commits, (1) ay profiles/schedules (2) controller/pages and other rest api stuff (3) tests. But it is not really necessary.

lib/YaST/Firstboot/FirstbootController.pm Outdated Show resolved Hide resolved
lib/YaST/Firstboot/GenericPage.pm Outdated Show resolved Hide resolved
lib/YaST/Firstboot/GenericPage.pm Show resolved Hide resolved
lib/YuiRestClient.pm Show resolved Hide resolved
Copy link
Member

@rwx788 rwx788 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very promising, couple of very minor points.

data/autoyast_sle15/autoyast_firstboot.xml Outdated Show resolved Hide resolved
data/autoyast_sle15/autoyast_firstboot.xml Outdated Show resolved Hide resolved
data/autoyast_sle15/autoyast_firstboot.xml Show resolved Hide resolved
tests/installation/enable_y2_firstboot.pm Outdated Show resolved Hide resolved
tests/installation/setup_libyui_firstboot.pm Show resolved Hide resolved
@JRivrain JRivrain force-pushed the firstboot_libyui branch 2 times, most recently from cc1bfb9 to f30ea53 Compare April 9, 2021 09:34
@JRivrain JRivrain changed the title Enable POM structure and libyui for firstboot [WIP] Enable POM structure and libyui for firstboot Apr 9, 2021
JRivrain added a commit to JRivrain/os-autoinst-needles-opensuse that referenced this pull request Apr 9, 2021
JRivrain added a commit to JRivrain/os-autoinst-needles-opensuse that referenced this pull request Apr 9, 2021
@JRivrain JRivrain changed the title [WIP] Enable POM structure and libyui for firstboot Enable POM structure and libyui for firstboot Apr 9, 2021
@JRivrain JRivrain changed the title Enable POM structure and libyui for firstboot [WIP] Enable POM structure and libyui for firstboot Apr 9, 2021
@JRivrain JRivrain changed the title [WIP] Enable POM structure and libyui for firstboot Enable POM structure and libyui for firstboot Apr 9, 2021
@JRivrain
Copy link
Contributor Author

JRivrain commented Apr 9, 2021

LGTM, some minor things, comments or some variables to remove.

Feel free (optionally) if you want to offer more granularity, at least I see 3 commits, (1) ay profiles/schedules (2) controller/pages and other rest api stuff (3) tests. But it is not really necessary.

I agree it would be nicer, but a bit complicated at that point. Next time I'll try to be more granular.

Copy link
Member

@rwx788 rwx788 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we are good to merge and keep introduce further improvements.

@jknphy jknphy merged commit e6e0966 into os-autoinst:master Apr 12, 2021
@DimStar77
Copy link
Contributor

https://openqa.opensuse.org/tests/1696355#next_previous

This fails in TW (makes me wonder about the verification runs executed, but TW also moved from libyui 4.1 to 4.2)

so, the question basically is: test bug or product bug?

@rwx788
Copy link
Member

rwx788 commented Apr 12, 2021

https://openqa.opensuse.org/tests/1696355#next_previous

This fails in TW (makes me wonder about the verification runs executed, but TW also moved from libyui 4.1 to 4.2)

so, the question basically is: test bug or product bug?

There is variable missing, we will take care of fixing this. Sorry for the noise, I'm testing the patch here: https://openqa.opensuse.org/tests/1696774

@DimStar77
Copy link
Contributor

There is variable missing, we will take care of fixing this. Sorry for the noise, I'm testing the patch here: https://openqa.opensuse.org/tests/1696774

Thank you! I tagged three test fails with poo#89866 - if your fix/test run works, I'd appreciate you adjusting the variables as needed for all the ones tagged

@JRivrain
Copy link
Contributor Author

JRivrain commented Apr 12, 2021

Still failing for autoyast, however if I clone it to my workstation, it works. I could not find any difference between the two, same code, same variables, same profile :'( . Anyway, not a product bug as it passed for me also in the last build: http://waaa-amazing.suse.cz/tests/15010.
But on o3, it looks like libyui does not get installed.
o3_nofirstboot
I can only assume that "zypper ar" fails as the worker cannot reach the repository. I could not connect to it with VNC to verify that assumption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants