-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create hdd for libyui tests #12468
Create hdd for libyui tests #12468
Conversation
8066432
to
69cf975
Compare
1b1f26c
to
82dcf33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. Some things I spot:
- Wondering if we should try with another arch in SLE, but we just might configure it in prod, the creation process is the same for the rest of archs.
- Check typo in commit "Remove scc_cneanup from schedule yast2_gui"
- Does it work for firstboot, I don't see it clearly in latest verification, perhaps is outdated.
- Similar for tw, could you share verification for https://openqa.opensuse.org/tests/1729867 so we don't miss anything. Did you find any difference for Leap https://openqa.opensuse.org/tests/1724090 ?
I had some issues yesterday with my workstation. It doesn't see any needles and tests fail. I will move all teh vrs to development group today |
24bafb3
to
8f54772
Compare
I noticed in the VR that for s390x the name that is publish and the name that is picked in the child is different, therefore fails. |
The test doesn't publish any image, for some reason I don't understand. I will try to add svirt_upload_assets in the schedule.
I changed that yesterday. Now it fails because of some scc problem. The test cannot install yast2-firstboot. |
you have custom SCC_URL, instead of http://all-187.1.proxy.scc.suse.de which probably is affecting registration. |
The custom scc url is not the problem here. I have the same url for x86_64 and it works. The firstboot tests don't run for other arch than x86_64 in productions, so there is a change that our scc never had those packages for ppc and aarch64. I will try to ask someone from scc team. But these failed tests shouldn't worry us for the merging of the PR.
What dependency is missing? How would a child test affect the image of the parent test from publishing? |
LGTM |
SLE: https://openqa.suse.de/tests/overview?distri=sle&version=15-SP3&build=_ssyrianidou_2&groupid=96
Tumbleweed: https://openqa.opensuse.org/tests/1731761
https://openqa.opensuse.org/tests/1731762
https://openqa.opensuse.org/tests/1731763