Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create hdd for libyui tests #12468

Merged
merged 3 commits into from
May 14, 2021
Merged

Conversation

@sofiasyria sofiasyria changed the title [WIP] Create hdd for libyui tests Create hdd for libyui tests May 4, 2021
@sofiasyria sofiasyria changed the title Create hdd for libyui tests [WIP] Create hdd for libyui tests May 4, 2021
@sofiasyria sofiasyria force-pushed the image_libyui branch 2 times, most recently from 8066432 to 69cf975 Compare May 4, 2021 13:50
tests/console/just_install_packages.pm Outdated Show resolved Hide resolved
tests/console/just_install_packages.pm Outdated Show resolved Hide resolved
@sofiasyria sofiasyria force-pushed the image_libyui branch 2 times, most recently from 1b1f26c to 82dcf33 Compare May 5, 2021 12:40
@sofiasyria sofiasyria changed the title [WIP] Create hdd for libyui tests Create hdd for libyui tests May 5, 2021
@sofiasyria sofiasyria changed the title Create hdd for libyui tests [WIP] Create hdd for libyui tests May 6, 2021
@sofiasyria sofiasyria changed the title [WIP] Create hdd for libyui tests Create hdd for libyui tests May 6, 2021
@sofiasyria sofiasyria changed the title Create hdd for libyui tests [WIP] Create hdd for libyui tests May 6, 2021
@sofiasyria sofiasyria changed the title [WIP] Create hdd for libyui tests Create hdd for libyui tests May 6, 2021
Copy link
Contributor

@jknphy jknphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Some things I spot:

  • Wondering if we should try with another arch in SLE, but we just might configure it in prod, the creation process is the same for the rest of archs.
  • Check typo in commit "Remove scc_cneanup from schedule yast2_gui"
  • Does it work for firstboot, I don't see it clearly in latest verification, perhaps is outdated.
  • Similar for tw, could you share verification for https://openqa.opensuse.org/tests/1729867 so we don't miss anything. Did you find any difference for Leap https://openqa.opensuse.org/tests/1724090 ?

schedule/yast/libyui_hdd.yaml Outdated Show resolved Hide resolved
@sofiasyria
Copy link
Contributor Author

* Does it work for firstboot, I don't see it clearly in latest verification, perhaps is outdated.

* Similar for tw, could you share verification for https://openqa.opensuse.org/tests/1729867 so we don't miss anything. Did you find any difference for Leap https://openqa.opensuse.org/tests/1724090 ?

I had some issues yesterday with my workstation. It doesn't see any needles and tests fail. I will move all teh vrs to development group today

@sofiasyria sofiasyria force-pushed the image_libyui branch 2 times, most recently from 24bafb3 to 8f54772 Compare May 7, 2021 11:22
@sofiasyria sofiasyria changed the title Create hdd for libyui tests [WIP] Create hdd for libyui tests May 7, 2021
@sofiasyria sofiasyria changed the title [WIP] Create hdd for libyui tests Create hdd for libyui tests May 12, 2021
@jknphy
Copy link
Contributor

jknphy commented May 13, 2021

I noticed in the VR that for s390x the name that is publish and the name that is picked in the child is different, therefore fails.
For the other ones failing I noticed you scheduled again, but check the WORKER_CLASS, it has two values, it should be fine removing one. If you can adjust that would be great, to be safe.
Other than that LGTM.

@sofiasyria
Copy link
Contributor Author

sofiasyria commented May 13, 2021

I noticed in the VR that for s390x the name that is publish and the name that is picked in the child is different, therefore fails.

The test doesn't publish any image, for some reason I don't understand. I will try to add svirt_upload_assets in the schedule.

For the other ones failing I noticed you scheduled again, but check the WORKER_CLASS, it has two values, it should be fine removing one. If you can adjust that would be great, to be safe.

I changed that yesterday. Now it fails because of some scc problem. The test cannot install yast2-firstboot.

@jknphy
Copy link
Contributor

jknphy commented May 13, 2021

you have custom SCC_URL, instead of http://all-187.1.proxy.scc.suse.de which probably is affecting registration.
for the images in s390x looks like isos post was not triggered right, because there is not dependency tab in https://openqa.suse.de/tests/6007410

@sofiasyria sofiasyria changed the title Create hdd for libyui tests [WIP] Create hdd for libyui tests May 13, 2021
@sofiasyria
Copy link
Contributor Author

you have custom SCC_URL, instead of http://all-187.1.proxy.scc.suse.de which probably is affecting registration.

The custom scc url is not the problem here. I have the same url for x86_64 and it works. The firstboot tests don't run for other arch than x86_64 in productions, so there is a change that our scc never had those packages for ppc and aarch64. I will try to ask someone from scc team. But these failed tests shouldn't worry us for the merging of the PR.

for the images in s390x looks like isos post was not triggered right, because there is not dependency tab in https://openqa.suse.de/tests/6007410

What dependency is missing? How would a child test affect the image of the parent test from publishing?

@sofiasyria sofiasyria changed the title [WIP] Create hdd for libyui tests Create hdd for libyui tests May 13, 2021
@jknphy
Copy link
Contributor

jknphy commented May 14, 2021

LGTM

@jknphy jknphy merged commit 49186d6 into os-autoinst:master May 14, 2021
@sofiasyria sofiasyria deleted the image_libyui branch May 17, 2021 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants