Make yast2_lan_restart_* modules work on svirt-xen-hvm #12504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwx788
reviewed
May 7, 2021
added 2 commits
May 7, 2021 15:56
For cases when network is restarted during test execution and IP address of SUT is changed, YuiRestClient needs to know the new IP address to be able to communicate with the SUT on remote installations. The commit adds the appropriate setters for host and port, so that the host can be changed at any time.
yast2_lan_restart_* test modules are using libyui, but it was not set up. The commit sets up libyui. Related ticket: https://progress.opensuse.org/issues/90773
OleksandrOrlov
force-pushed
the
90773_setup_libyui_hvm
branch
from
f9c4acd
to
81759cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was using YRestClient in some internal functions, but the Client was not set up.
The PR sets it up.
Also, I've adjusted the test to properly check that network is restarted and it found a bug, which I've raised on bugzilla: https://bugzilla.suse.com/show_bug.cgi?id=1185775
So, the failures are expected and they show that the issue exists.