Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/utils: Fix get_x11_console_tty for upgrades from 42.x #12579

Merged
merged 1 commit into from
May 21, 2021

Conversation

Vogtinator
Copy link
Member

After upgrading from 42.x to the current version, the new settings apply.
So just remove the check for the HDD version.

Related ticket: https://progress.opensuse.org/issues/91545
Verification runs:
15.3: https://openqa.opensuse.org/t1751232
TW: https://openqa.opensuse.org/t1751231

After upgrading from 42.x to the current version, the new settings apply.
So just remove the check for the HDD version.
@Vogtinator Vogtinator requested a review from DimStar77 May 21, 2021 09:07
@DimStar77
Copy link
Contributor

I guess the zdup cases from 42.x to 'modern' might be negatively impacted here (if they even ever try to switch back - don't think that would be really needed)

for TW, there is no risk, as dup from 42.x is not supported anyway (rpm compression scheme change); the 15.x -> TW zdup I checked seem not to do any VT siwtch back to GUI before boot - so we should also be safe from that perspective

@Vogtinator
Copy link
Member Author

I guess the zdup cases from 42.x to 'modern' might be negatively impacted here (if they even ever try to switch back - don't think that would be really needed)

Yes, those would need something like the migration/version_switch_upgrade_target.pm or extra code in post_zdup. For 42 not relevant, but might change in the future for zdup from 15.x.

for TW, there is no risk, as dup from 42.x is not supported anyway (rpm compression scheme change); the 15.x -> TW zdup I checked seem not to do any VT siwtch back to GUI before boot - so we should also be safe from that perspective

42.x to 15.3 is also broken: https://openqa.opensuse.org/tests/1739027

@Vogtinator
Copy link
Member Author

for TW, there is no risk, as dup from 42.x is not supported anyway (rpm compression scheme change); the 15.x -> TW zdup I checked seem not to do any VT siwtch back to GUI before boot - so we should also be safe from that perspective

42.x to 15.3 is also broken: https://openqa.opensuse.org/tests/1739027

And I just deleted those: https://progress.opensuse.org/issues/89263

@Vogtinator Vogtinator marked this pull request as ready for review May 21, 2021 11:06
@Vogtinator Vogtinator merged commit a70b545 into os-autoinst:master May 21, 2021
@Vogtinator Vogtinator deleted the 42upgfix branch May 21, 2021 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants