Adapt YaST Firstboot scenario to use REST API #12610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jknphy
commented
May 27, 2021
jknphy
commented
- Related ticket: poo#91581
- Job group MR: MR#354
- Verification run: O3 | SLE
jknphy
force-pushed
the
adapt_yast2_firstboot
branch
2 times, most recently
from
1bc2c13
to
fc4a36e
Compare
jknphy
force-pushed
the
adapt_yast2_firstboot
branch
from
fc4a36e
to
b3b9148
Compare
jknphy
changed the title
jknphy
force-pushed
the
adapt_yast2_firstboot
branch
9 times, most recently
from
130af89
to
c23a4a9
Compare
jknphy
force-pushed
the
adapt_yast2_firstboot
branch
2 times, most recently
from
f59b024
to
1f23612
Compare
jknphy
force-pushed
the
adapt_yast2_firstboot
branch
2 times, most recently
from
ba580bc
to
c97fac8
Compare
jknphy
changed the title
OleksandrOrlov
approved these changes
May 31, 2021
There was a problem hiding this comment.
Very big and painstaking work! Now we have pages for, probably, almost whole installation process. It is amazing how the result look like and it definitely will help us to convert the existing installation test cases to use Page Object Model approach quickier.
Thank you a lot for the input!
|
There is a regression showing up, likely from this change: https://openqa.opensuse.org/tests/1762665#step/snapshots_small_root/4 |
jknphy
added a commit
to jknphy/os-autoinst-distri-opensuse
that referenced
this pull request
Jun 1, 2021
Warnings for now can be evaluated as part of the navigation or in the test itself. This fix the possibility to assert its text in the test, which was broken in PR os-autoinst#12610.
thanks for noticing, fixed in #12632 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.