Containers: disable firewall by default #12724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some versions, we have firewall running and in some others firewall is disabled. This way we make sure we start the test with the same conditions for all the cases. The reason to choose disabled is to avoid some further configuration of iptables to allow containers contact the public network (bsc#1187176) Since container tests are not targetting network testing, it makes sense to run the general tests with additional network setup. What we can do in the other hand is to create a new test case where we test container networking with firewall enabled.
|
VRs: SLE image updates (incompleted) |
mloviska
approved these changes
Jun 17, 2021
Can you please create a ticket to not forget about this and we are done |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some versions, we have firewall running and in some others firewall
is disabled. This way we make sure we start the test with the same
conditions for all the cases.
The reason to choose disabled is to avoid some further configuration
of iptables to allow containers contact the public network (bsc#1187176)
Since container tests are not targeting network testing, it makes
sense to run the general tests with additional network setup.
What we can do in the other hand is to create a new test case where
we test container networking with firewall enabled.