Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use separate log file for LibyuiClient #12730

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

OleksandrOrlov
Copy link
Contributor

@OleksandrOrlov OleksandrOrlov commented Jun 17, 2021

Log LibyuiClient calls to separate from autoinst-log.txt file.

@OleksandrOrlov OleksandrOrlov added the WIP Work in progress label Jun 17, 2021
@OleksandrOrlov OleksandrOrlov force-pushed the 89485_separate_log_libyui branch 10 times, most recently from 19dd7fa to 3ce7271 Compare June 18, 2021 09:57
Copy link
Contributor

@jknphy jknphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job researching this solution!
Just some comments about the structure of the code.
Btw if you could provide some VR failing instead of user cancelled perhaps would more clear to check.

lib/y2_installbase.pm Outdated Show resolved Hide resolved
lib/y2_base.pm Outdated Show resolved Hide resolved
lib/y2_base.pm Outdated Show resolved Hide resolved
lib/YuiRestClient/App.pm Outdated Show resolved Hide resolved
lib/YuiRestClient/Logger.pm Outdated Show resolved Hide resolved
lib/YuiRestClient/Logger.pm Show resolved Hide resolved
lib/YuiRestClient/Logger.pm Outdated Show resolved Hide resolved
lib/YuiRestClient/Logger.pm Outdated Show resolved Hide resolved
lib/YuiRestClient.pm Outdated Show resolved Hide resolved
lib/YuiRestClient.pm Outdated Show resolved Hide resolved
@OleksandrOrlov OleksandrOrlov removed the WIP Work in progress label Jun 22, 2021
@OleksandrOrlov OleksandrOrlov force-pushed the 89485_separate_log_libyui branch 2 times, most recently from c8513b5 to 03e536d Compare June 23, 2021 12:13
products/opensuse/main.pm Outdated Show resolved Hide resolved
Log LibyuiClient calls to separate from autoinst-log.txt file

Related ticket: https://progress.opensuse.org/issues/89485
@jknphy
Copy link
Contributor

jknphy commented Jun 28, 2021

Looks really useful the logs as seen in the failed verification.
Once you run it with the fake commit I would recommend to stash or save it locally in another branch and drop if from remote, if you keep the commit, putting on WIP the PR would help the reviewer, I almost merge it :)
Alternative, in the first comment you can specify the exact command to run before merge it to delete a commit in a PR not owned by oneself (if it is simple command not some complicated rebase). I'm not sure if that exists :) ... just thinking loud.
Let me know when you are ready.

@OleksandrOrlov
Copy link
Contributor Author

@jknphy Removed the additional commit.

@jknphy jknphy merged commit c387750 into os-autoinst:master Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants