Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with disabled SSH password login #12747

Merged
merged 1 commit into from Jun 21, 2021

Conversation

pdostal
Copy link
Member

@pdostal pdostal commented Jun 20, 2021

As this problem appeared on Tumbleweed where the new directory
/etc/ssh/sshd_config.d/ is in place I'm checking for it.

@pdostal pdostal requested a review from DimStar77 June 20, 2021 01:09
@pdostal pdostal mentioned this pull request Jun 20, 2021
@DimStar77
Copy link
Contributor

since c6d4918 we have a permit_root_ssh function in lib/utils.pm

Any chance to reuse that one here as well?

@rfan1
Copy link
Contributor

rfan1 commented Jun 21, 2021

since c6d4918 we have a permit_root_ssh function in lib/utils.pm

Any chance to reuse that one here as well?

Yes, #12697

@DimStar77
Copy link
Contributor

since c6d4918 we have a permit_root_ssh function in lib/utils.pm
Any chance to reuse that one here as well?

Yes, #12697

that was the MR that merged the commit I referenced - but that commit does not fix the multimachine setups for tests like wireguard - so I'm not really sure I understand your comment

@rfan1
Copy link
Contributor

rfan1 commented Jun 21, 2021

since c6d4918 we have a permit_root_ssh function in lib/utils.pm
Any chance to reuse that one here as well?

Yes, #12697

that was the MR that merged the commit I referenced - but that commit does not fix the multimachine setups for tests like wireguard - so I'm not really sure I understand your comment

Just adding my PR for my commit "permit_root_ssh" function, hopefully it can help.

@pdostal
Copy link
Member Author

pdostal commented Jun 21, 2021

Thank you, @DimStar77, @rfan1 ! :) I will update my PR.

@DimStar77
Copy link
Contributor

Thanks for the updated PR - can you please ensure there is an up-to-date verification run linked?

As this problem appeared on Tumbleweed where the new directory
`/etc/ssh/sshd_config.d/` is in place I'm checking for it.
@pdostal
Copy link
Member Author

pdostal commented Jun 21, 2021

@DimStar77 foxed, reverified. Thank you!

@DimStar77
Copy link
Contributor

AS this is a multi-machine test: can you please verify what happened to the linked/dependent tests?

http://pdostal-server.suse.cz/tests/12190#dependencies -> client failed

@pdostal
Copy link
Member Author

pdostal commented Jun 21, 2021

AS this is a multi-machine test: can you please verify what happened to the linked/dependent tests?

http://pdostal-server.suse.cz/tests/12190#dependencies -> client failed

that is unrelated to the issue. I added fixed openVPN run and added Wireguard run.

@DimStar77 DimStar77 merged commit 2225196 into os-autoinst:master Jun 21, 2021
@pdostal pdostal deleted the tw_ssh branch December 28, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready Ready for review
Projects
None yet
3 participants